Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If you havent added region:global the modal doesnt popup #958

Open
GretaD opened this issue Jul 24, 2024 · 1 comment
Open

If you havent added region:global the modal doesnt popup #958

GretaD opened this issue Jul 24, 2024 · 1 comment
Assignees
@GretaD
Labels
1. to develop bug

Comments

@GretaD
Copy link
Collaborator

GretaD commented Jul 24, 2024

Found out while working on #950
@GretaD GretaD self-assigned this Jul 24, 2024
@nickvergessen
Copy link
Member

Just for the record. You just need a "global" region, the language actually doesn't matter.
The reason is that you most likely test with "localhost" aka 127.0.0.1 or ::1 or any other "local IP", which is not a country and therefore goes to country "global".

So this is sometime expected, but it is a good hint.
I think a warning should be shown in the admin settings if you define terms for any region and there is no "global" region terms.

@nickvergessen nickvergessen changed the title If you havent added region:global, language: english, the modal doesnt popup If you havent added region:global the modal doesnt popup Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GretaD GretaD

Labels
1. to develop bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickvergessen @GretaD