Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better indicate dropping on empty completed list #1170

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Better indicate dropping on empty completed list #1170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion css/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,10 @@ $blue_due: #4271a6; // due dates and low importance
z-index: 10;
}

&.completed {
margin-top: 12px;
}

// Show round corners for first root task
> .task-item {
&:first-child > .task-body {
Expand Down Expand Up @@ -776,14 +780,15 @@ $blue_due: #4271a6; // due dates and low importance
.heading {
display: flex;
align-items: center;
margin-bottom: 10px;
margin-top: 20px !important;

@media only screen and (max-width: $breakpoint-mobile) {
padding-left: 15px;
}

&--hiddentasks {
margin-bottom: 0;

.heading__title {
display: inline-block;
padding-right: 16px;
Expand Down
1 change: 1 addition & 0 deletions src/components/TheCollections/Calendar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ License along with this library. If not, see <http://www.gnu.org/licenses/>.
:tasks="completedRootTasks(calendar.tasks)"
:calendar-id="calendarId"
:disabled="calendar.readOnly"
class="completed"
collection-id="completed" />
<LoadCompletedButton :calendar="calendar" />
<DeleteCompletedModal v-if="calendar.loadedCompleted && !calendar.readOnly" :calendar="calendar" />
Expand Down