Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better indicate dropping on empty completed list #1170

Merged
merged 1 commit into from
Aug 3, 2020

Conversation

raimund-schluessler
Copy link
Member

When dragging a task to the last position in the list it could happen, that it was marked as completed, since the empty completed list had no spacer to the normal list. We now have a small distance to the completed list, so it is more obivous a task will be completed.

Before:
before

After:
after

@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #1170 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   27.74%   27.74%           
=======================================
  Files          48       48           
  Lines        2656     2656           
  Branches      523      523           
=======================================
  Hits          737      737           
  Misses       1778     1778           
  Partials      141      141           

@raimund-schluessler raimund-schluessler added this to the 0.14.0 milestone Aug 3, 2020
@raimund-schluessler raimund-schluessler merged commit 4683c3b into master Aug 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/drop-completed branch August 3, 2020 18:49
@raimund-schluessler raimund-schluessler modified the milestones: 0.14.0, 0.13.4 Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant