Force inactive users to leave the room #935
Conversation
lib/Controller/RoomController.php
Outdated
| }); | ||
|
|
||
| foreach ($inactiveUsers as $inactiveUserId => $data) { | ||
| $room->leaveRoom($inactiveUserId); |
There was a problem hiding this comment.
Needs cast to (string) IIRC for users with only numbers as user id.
There was a problem hiding this comment.
Also I think a "format" function is not the right place for such logic?
There was a problem hiding this comment.
Needs cast to (string) IIRC for users with only numbers as user id.
I will add the cast.
Also I think a "format" function is not the right place for such logic?
I also think that it is not the right place, but I just put it where the kick out code for guest participants already was.
There was a problem hiding this comment.
Ping, we want to do a release this week :)
lib/Controller/RoomController.php
Outdated
| @@ -219,6 +219,15 @@ protected function formatRoom(Room $room, Participant $participant = null) { | |||
| } | |||
| } | |||
|
|
|||
| $inactiveUsers = array_filter($participants['users'], function($data) { | |||
| return $data['lastPing'] <= time() - 30 && | |||
There was a problem hiding this comment.
This is a bit drastic? If one ping lags, you get killed out of the room.
The user tries 3 (or5) reconnects.
There was a problem hiding this comment.
I just used the same timeout already being used for guests. Should I increase the timeout for both? Only for registered users? Or leave it like it is now?
There was a problem hiding this comment.
Please use 100 seconds, so we are in 3 pings a 30 seconds + buffer
Lines 660 to 664 in db5861e
Inactive guests (those that have not sent a ping in the last 30 seconds) are automatically cleaned from a room when the information for that room is got. In the same way, now inactive users are forced to leave the room too when the information for the room is got. Although all inactive guests are cleaned all at once inactive users are forced to leave the room one by one (each one with its own SQL query); although it would be better to force all the inactive users to leave the room at once this should not be a big problem, as users would usually leave the room cleanly; only crashed clients or other exceptional situations should cause a user to be inactive. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
When a user leaves a room the "in call" flag is also reset. As users are now forced to leave the room when they are inactive it is no longer needed to reset the flag using a background job. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
… buffer) Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
force-inactive-users-to-leave-the-room
branch
from
1983bc5
to
7a50561
Compare
Inactive guests (those that have not sent a ping in the last 30 seconds) are automatically cleaned from a room when the information for that room is got. In the same way, now inactive users are forced to leave the room too when the information for the room is got.
As leaving a room also resets its in call flag it is no longer needed to reset that flag using a background job.
How to test:
Expected results:
The original user is no longer listed as in call (camera icon next to her name in the participant list) nor as in room (avatar not dimmed in the participant list).
Actual results:
If waited for less than five minutes, the original user is listed both as in call and as in room.
If waited for more than five minutes (and the background jobs run), the original user is not listed as in call, but she is still listed as in room.