Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force inactive users to leave the room #935

Merged
merged 3 commits into from
Jul 10, 2018
Merged

Force inactive users to leave the room #935

merged 3 commits into from
Jul 10, 2018

Commits on Jul 10, 2018

  1. Force inactive users to leave the room 

    Inactive guests (those that have not sent a ping in the last 30 seconds)
are automatically cleaned from a room when the information for that room
is got. In the same way, now inactive users are forced to leave the room
too when the information for the room is got.

Although all inactive guests are cleaned all at once inactive users are
forced to leave the room one by one (each one with its own SQL query);
although it would be better to force all the inactive users to leave the
room at once this should not be a big problem, as users would usually
leave the room cleanly; only crashed clients or other exceptional
situations should cause a user to be inactive.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @nickvergessen
    danxuliu authored and nickvergessen committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    efad428 View commit details
    Browse the repository at this point in the history

  2. Remove background job to reset "in call" flag 

    When a user leaves a room the "in call" flag is also reset. As users are
now forced to leave the room when they are inactive it is no longer
needed to reset the flag using a background job.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @nickvergessen
    danxuliu authored and nickvergessen committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    d9f07fb View commit details
    Browse the repository at this point in the history

  3. Simplify the code and allow 100 secs as timeout (3 pings and a little… 

    … buffer)

Signed-off-by: Joas Schilling <[email protected]>
    @nickvergessen
    nickvergessen committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    7a50561 View commit details
    Browse the repository at this point in the history