-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement link previews #7822
Implement link previews #7822
Conversation
From the design review with @jancborchardt but might be a follow up:
|
Definetly something for later. as we should first move to the RichContenteditable before duck typing a bigger hole within this already too overbloated component. |
Moved the other open questions also to new issues so they can be done as a follow up |
Will bump the lib to 2.0.0 and fix eslint |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
3217159
to
b5c5b4a
Compare
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@nickvergessen Quick update, I did a follow up for the frontend bits and missed that i included the event in there. nextcloud/server#33755 adds that and I prepared a commit to either merge afterwards or cherry pick to this PR: f627c84 |
But that is only for the "special" handling of files/talk/... not for general link previews, right? |
Yes, we can also add the event in a follow up. |
Created #7837 |
Does anyone know how to enable this? This was marked as completed but for me link previews still show like this. This issue for this feature was here: And was marked as a duplicate of this. |
Decide if the link metadata should be fetched upfront when fetching the message list maybe=> Moved to Should we fetch link preview data when returning messages already #7833Figure out a proper way to set the width=> Moved to Fix link preview width when chat is in the sidebar #7832