Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement link previews #7822

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Implement link previews #7822

merged 6 commits into from
Aug 31, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 30, 2022

Screenshot 2022-08-30 at 08 59 24

@nickvergessen
Copy link
Member

For me links are not clickable anymore?
Bildschirmfoto vom 2022-08-31 08-58-46

@juliusknorr
Copy link
Member Author

juliusknorr commented Aug 31, 2022

From the design review with @jancborchardt but might be a follow up:

@nickvergessen
Copy link
Member

Talk could show this preview already when you paste a link in the composer, above your text, much like e.g. Signal does (similar style as for replying to others)

Definetly something for later. as we should first move to the RichContenteditable before duck typing a bigger hole within this already too overbloated component.

@nickvergessen
Copy link
Member

Moved the other open questions also to new issues so they can be done as a follow up

@nickvergessen
Copy link
Member

Will bump the lib to 2.0.0 and fix eslint

juliusknorr and others added 4 commits August 31, 2022 15:50
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
@juliusknorr
Copy link
Member Author

@nickvergessen Quick update, I did a follow up for the frontend bits and missed that i included the event in there. nextcloud/server#33755 adds that and I prepared a commit to either merge afterwards or cherry pick to this PR: f627c84

@nickvergessen
Copy link
Member

But that is only for the "special" handling of files/talk/... not for general link previews, right?

@juliusknorr
Copy link
Member Author

Yes, we can also add the event in a follow up.

@nickvergessen nickvergessen marked this pull request as ready for review August 31, 2022 19:01
@nickvergessen
Copy link
Member

Created #7837

@nickvergessen nickvergessen merged commit db1af53 into master Aug 31, 2022
@nickvergessen nickvergessen deleted the enh/references branch August 31, 2022 19:03
@Renari
Copy link

Renari commented Jun 8, 2024

Does anyone know how to enable this? This was marked as completed but for me link previews still show like this.

instead of this:

This issue for this feature was here:
nextcloud/server#32979

And was marked as a duplicate of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants