-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend for reference metadata fetching #33494
Conversation
4b2fb66
to
445ea5f
Compare
445ea5f
to
84437c2
Compare
84437c2
to
7dba179
Compare
It took me so long to understand what this is about, so, for other unaware reviewers: And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted. |
Sorry, should have clarified that a bit more, but I've taken your description for the first post in addition |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
424020a
to
94ee906
Compare
lib/private/Collaboration/Reference/File/FileReferenceProvider.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Julius Härtl <[email protected]>
94ee906
to
1ab6698
Compare
Failures unrelated |
/** | ||
* Return true if the reference metadata can be globally cached | ||
* | ||
* @since 25.0.0 | ||
*/ | ||
public function getCachePrefix(string $referenceId): string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phpdoc description is wrong
Summary
This is about showing a preview of links posted in Talk, like what is done when posting links on other chat platforms.
And this is the backend part, is not specific to Talk, and may not be specific to links in the future, which is what makes the original description convoluted.
This PR implements an API to be used to generate a rich preview rendering of references (which are links in the first iteration). The backend gathers additional metadata for references through different providers, which can be added by apps, but there is a fallback to an open graph provider by default. The open graph extraction can be turned off through config.php.
ToDo
Backend
Integration
Provider implementations