[stable17] Enable join button by default in public share pages #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The join button was initially disabled in public share pages and enabled once the Talk sidebar was fully shown. As the Talk sidebar is shown using a transition showing the Talk sidebar had to be delayed after the page load, as in some cases the transition was ignored and the sidebar was immediately shown. When that happened, as there was no transition, the join button was never enabled. However, despite using a delay of one second in some cases (apparently if the system load is high) the transition did not happen either. Instead of increasing the delay even more, which does not guarantee anything, now the join button is enabled since the beginning. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
danxuliu
added
3. to review
bug
feature: talk-sidebar ⬅️
nickvergessen
approved these changes
Nov 12, 2019
nickvergessen
deleted the
enable-join-button-by-default-in-public-share-pages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2347
The join button was initially disabled in public share pages and enabled once the Talk sidebar was fully shown. As the Talk sidebar is shown using a transition showing the Talk sidebar had to be delayed after the page load, as in some cases the transition was ignored and the sidebar was immediately shown. When that happened, as there was no transition, the join button was never enabled.
However, despite using a delay of one second in some cases (apparently if the system load is high) the transition did not happen either. Instead of increasing the delay even more, which does not guarantee anything, now the join button is enabled since the beginning.