Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Enable join button by default in public share pages #2456

Merged
merged 1 commit into from
Nov 12, 2019
Merged

[stable17] Enable join button by default in public share pages #2456

merged 1 commit into from
Nov 12, 2019

Commits on Nov 12, 2019

  1. Enable join button by default in public share pages 

    The join button was initially disabled in public share pages and enabled
once the Talk sidebar was fully shown. As the Talk sidebar is shown
using a transition showing the Talk sidebar had to be delayed after the
page load, as in some cases the transition was ignored and the sidebar
was immediately shown. When that happened, as there was no transition,
the join button was never enabled.

However, despite using a delay of one second in some cases (apparently
if the system load is high) the transition did not happen either.
Instead of increasing the delay even more, which does not guarantee
anything, now the join button is enabled since the beginning.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu
    danxuliu committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    1158c08 View commit details
    Browse the repository at this point in the history