Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable17] Better general setting #2342

Merged
merged 6 commits into from
Oct 22, 2019
Merged

[stable17] Better general setting #2342

merged 6 commits into from
Oct 22, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 21, 2019 •
edited
Loading

Backport of #2281
Backport of #2341
Backport of #2283

@nickvergessen nickvergessen added this to the 💙 Next Minor (17) milestone Oct 21, 2019
@nickvergessen nickvergessen changed the title [stable17] Better "start call" setting [stable17] Better general setting Oct 21, 2019
danxuliu
danxuliu approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

Acceptance test failure is a hiccup (it worked when run locally).

@danxuliu danxuliu merged commit 142f91e into stable17 Oct 22, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/2281/stable17 branch October 22, 2019 11:11
@danxuliu danxuliu mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

Assignees
No one assigned
Labels
3. to review bug
Projects
None yet
Milestone
7.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nickvergessen @danxuliu