Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable file rooms #2283

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Allow to disable file rooms #2283

merged 1 commit into from
Oct 21, 2019

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Oct 8, 2019 •
edited
Loading

Bildschirmfoto von 2019-10-08 11-49-00

Fix #2280

@nickvergessen nickvergessen added 3. to review enhancement feature: settings ⚙️ Settings and config related issues feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Oct 8, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Oct 8, 2019
@nickvergessen nickvergessen force-pushed the feature/2280/allow-to-disable-file-rooms branch from 2475dad to e74df78 Compare October 8, 2019 09:56
Ivansss
Ivansss approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

danxuliu
danxuliu reviewed Oct 8, 2019
View reviewed changes
lib/Controller/FilesIntegrationController.php Outdated Show resolved Hide resolved
lib/Files/TemplateLoader.php Outdated Show resolved Hide resolved
lib/PublicShare/TemplateLoader.php Outdated Show resolved Hide resolved
@nickvergessen nickvergessen force-pushed the feature/2280/allow-to-disable-file-rooms branch from e74df78 to 83f0cda Compare October 8, 2019 11:01
@nickvergessen
Copy link
Member Author

Changed all of them

danxuliu
danxuliu approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@Ivansss Ivansss mentioned this pull request Oct 8, 2019
Open
@nickvergessen nickvergessen force-pushed the feature/2280/allow-to-disable-file-rooms branch from 83f0cda to 5ab5ff4 Compare October 21, 2019 13:14
@nickvergessen
Copy link
Member Author

Rebased after #2331

@nickvergessen nickvergessen mentioned this pull request Oct 21, 2019
Merged
@nickvergessen nickvergessen merged commit 293650b into master Oct 21, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/2280/allow-to-disable-file-rooms branch October 21, 2019 23:14
@danxuliu danxuliu mentioned this pull request Oct 22, 2019
Merged
@tigernero79
Copy link

When this is online, it changes because in 7.0.1 talk talk I can't find it.

@nickvergessen nickvergessen mentioned this pull request Mar 25, 2021
Closed
@thevril
Copy link

thevril commented Mar 31, 2023

does this feature still exist?

I've got an account on https://cloud.disroot.org
But I can't find this setting anywhere. The chat is active for every file I share.
I've tried to look for this setting also in a newer cloud with Nextcloud 25, but I didn't find anything!

Can someone write me in detail where is this setting?
Is this a setting for normal users or only for those who manage the server?

thank in advance!

@nickvergessen
Copy link
Member Author

Admin settings

@thevril
Copy link

thevril commented Mar 31, 2023

Admin settings

I'm sorry, but is like one hour that I'm searching this.

01
Cattura2

I do not find here this setting, what am I doing wrong?
The problem is that I'm not admin of the server?

@nickvergessen
Copy link
Member Author

The problem is that I'm not admin of the server?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@Ivansss Ivansss Ivansss approved these changes

Assignees
No one assigned
Labels
4. to release enhancement feature: settings ⚙️ Settings and config related issues feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging this pull request may close these issues.

Is it possible to deactivate talk on file sharing web pages?
5 participants
@nickvergessen @tigernero79 @thevril @Ivansss @danxuliu