Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor php issues #2245

Merged
merged 4 commits into from
Oct 2, 2019
Merged

Fix minor php issues #2245

merged 4 commits into from
Oct 2, 2019

Conversation

nickvergessen
Copy link
Member

Fix #2237

Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration and acceptance tests fail after merging the controllers.

@nickvergessen
Copy link
Member Author

Fixed, I hat this non-string userId for guests....

@nickvergessen nickvergessen force-pushed the bugfix/2237/fix-minor-php-issues branch from f6330d0 to d29b91d Compare October 1, 2019 07:25
@danxuliu danxuliu merged commit b493086 into master Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2237/fix-minor-php-issues branch October 2, 2019 08:54
@nickvergessen
Copy link
Member Author

/backport to stable17

@backportbot-nextcloud
Copy link

The backport to stable17 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the code quality of "Talk sidebar on public shares"
2 participants