Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the code quality of "Talk sidebar on public shares" #2237

Closed
nickvergessen opened this issue Sep 27, 2019 · 5 comments · Fixed by #2245
Closed

Improve the code quality of "Talk sidebar on public shares" #2237

nickvergessen opened this issue Sep 27, 2019 · 5 comments · Fixed by #2245
Assignees
@danxuliu
Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression
Milestone
v8.0.0

Comments

@nickvergessen
Copy link
Member

See open comments in #2107
@nickvergessen nickvergessen added 1. to develop bug regression feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Sep 27, 2019
@nickvergessen nickvergessen added this to the 💚 Next Major (18) milestone Sep 27, 2019
@nickvergessen nickvergessen mentioned this issue Sep 27, 2019
Merged
@jospoortvliet
Copy link
Member

Not sure if this is a Text, Viewer or Talk bug but the talk sidebar has an issue with the Call button being covered by a part of the Text viewer:
Screenshot_20190928_182258

I guess it's a CSS fix... ;-)

@nickvergessen
Copy link
Member Author

Reopening for the UI thing

@nickvergessen nickvergessen reopened this Oct 2, 2019
@danxuliu danxuliu mentioned this issue Oct 17, 2019
Closed
@nickvergessen
Copy link
Member Author

This is now done? @danxuliu

@danxuliu
Copy link
Member

No, not yet.

@jospoortvliet
Copy link
Member

It is fixed now, at least I don't see it anymore on cloud.nextcloud.com -> close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danxuliu danxuliu

Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents regression
Projects
None yet
Milestone
v8.0.0
Development

Successfully merging a pull request may close this issue.

Fix minor php issues nextcloud/spreed
3 participants
@nickvergessen @jospoortvliet @danxuliu