Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed additional and uneccessary request on password reset #7691

Closed
wants to merge 3 commits into from
Closed

Removed additional and uneccessary request on password reset #7691

wants to merge 3 commits into from

Conversation

lal12
Copy link
Contributor

@lal12 lal12 commented Jan 4, 2018

Addition to this PR: #7651

@lal12 lal12 mentioned this pull request Jan 4, 2018
Closed
@lal12 lal12 mentioned this pull request Jan 5, 2018
Closed
@rullzer
Copy link
Member

rullzer commented Jan 11, 2018

This slipped past my radar. I'll have a look here :)

rullzer
rullzer approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works and makes sense!

@rullzer
Copy link
Member

rullzer commented Jan 11, 2018

@lal12 works like a charm. Could you sign-off and squash your commits?

@MorrisJobke
Copy link
Member

@lal12 Do you need help with this? Just ask here or in our IRC at #nextcloud-dev on freenode.

@lal12
Copy link
Contributor Author

lal12 commented Jan 16, 2018 •
edited
Loading

@MorrisJobke I would or actually already tried, but my internet provider currently isn't able to provide internet. And over my neighbours connection I currently use, for what ever reason I cannot clone a git repo.

So it can take a week until I am able to do it. But if it has some kind of hurry, it would be no problem for me if you do it?

@MorrisJobke
Copy link
Member

So it can take a week until I am able to do it. But if it has some kind of hurry, it would be no problem for me if you do it?

Don't worry - we are not in a hurry here. Take your time and as soon as you have it we are here to guide you if you need assistance.

@lal12 lal12 closed this Jan 17, 2018
@lal12 lal12 deleted the bla branch January 17, 2018 14:39
@lal12 lal12 mentioned this pull request Jan 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lal12 @rullzer @MorrisJobke