Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed redirection after password reset #7651

Closed
wants to merge 1 commit into from
Closed

Fixed redirection after password reset #7651

wants to merge 1 commit into from

Conversation

lal12
Copy link
Contributor

@lal12 lal12 commented Dec 30, 2017

Fixed error in lostpassword.js, that prevented redirecting after password reset.

I described the error here: #7218

@lal12
Copy link
Contributor Author

lal12 commented Dec 30, 2017

Hmm, the test build reports failures, but most of them show a server related error message:

Error response from daemon: could not find an available, non-overlapping IPv4 address pool among the defaults to assign to the network

@@ -162,7 +162,7 @@ OC.Lostpassword = {
var resetErrorMsg;
if (result && result.status === 'success'){
$.post(
OC.webroot + '/',
OC.webroot + '/ocs/v1.php',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm posting to that endpoint makes no sense... why do we actually do that? to trigger the login or what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about that too. I just assumed it is to check whether the password changed. But usually this error should be reported by the response from the previous request. But I am not familiar with the next loud code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I remove this request instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year try it and see if it still works :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look here: #7691,
I accidentily deleted my fork...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok lets close this then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants