-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed redirection after password reset #7651
Conversation
Hmm, the test build reports failures, but most of them show a server related error message:
|
@@ -162,7 +162,7 @@ OC.Lostpassword = { | |||
var resetErrorMsg; | |||
if (result && result.status === 'success'){ | |||
$.post( | |||
OC.webroot + '/', | |||
OC.webroot + '/ocs/v1.php', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mmmm posting to that endpoint makes no sense... why do we actually do that? to trigger the login or what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered about that too. I just assumed it is to check whether the password changed. But usually this error should be reported by the response from the previous request. But I am not familiar with the next loud code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should I remove this request instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Year try it and see if it still works :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look here: #7691,
I accidentily deleted my fork...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok lets close this then
Fixed error in lostpassword.js, that prevented redirecting after password reset.
I described the error here: #7218