Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing #5337 based on Morris' feedback #7496

Closed
wants to merge 1 commit into from
Closed

Conversation

MariusBluem
Copy link
Member

@MariusBluem MariusBluem commented Dec 13, 2017

This may fix #5337 @MorrisJobke

Signed-off-by: Marius Blüm [email protected]

@MariusBluem MariusBluem added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Dec 13, 2017
@MariusBluem MariusBluem added this to the Nextcloud 13 milestone Dec 13, 2017
@MorrisJobke
Copy link
Member

I was wrong on this - it is the CSS of the gallery app 😢

@MorrisJobke MorrisJobke deleted the fix-5337 branch December 13, 2017 17:12
@MorrisJobke MorrisJobke removed this from the Nextcloud 13 milestone Dec 13, 2017
@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #7496 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #7496      +/-   ##
===========================================
- Coverage     51.11%   51.1%   -0.01%     
  Complexity    24901   24901              
===========================================
  Files          1601    1601              
  Lines         94774   94774              
  Branches       1367    1367              
===========================================
- Hits          48441   48436       -5     
- Misses        46333   46338       +5
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 91.08% <0%> (-1%) 39% <0%> (ø)
core/js/js.js 62.98% <0%> (-0.57%) 0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.28% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 81.01% <0%> (+0.11%) 134% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced sharing options margin
2 participants