Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced sharing options margin #5337

Closed
MariusBluem opened this issue Jun 11, 2017 · 11 comments
Closed

Advanced sharing options margin #5337

MariusBluem opened this issue Jun 11, 2017 · 11 comments
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Milestone
Nextcloud 14

Comments

@MariusBluem
Copy link
Member

MariusBluem commented Jun 11, 2017 •
edited by jancborchardt
Loading

Margin between the advanced sharing options does not match with other places :)

bildschirmfoto 2017-06-11 um 11 29 48

@nextcloud/designers @jancborchardt
@MariusBluem MariusBluem added design Design, UI, UX, etc. feature: sharing papercut Annoying recurring issue with possibly simple fix. labels Jun 11, 2017
@MorrisJobke MorrisJobke changed the title Advanced sharing options distance Advanced sharing options margin Jun 12, 2017
@jancborchardt
Copy link
Member

Yeah, that indeed seems like an awful lot of wbitespace. Which browser is this?

@MariusBluem
Copy link
Member Author

Safari 11 ...

@jancborchardt jancborchardt added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jun 12, 2017
@MariusBluem
Copy link
Member Author

any news on this :(

@MariusBluem
Copy link
Member Author

MariusBluem commented Dec 13, 2017 •
edited
Loading

Just reproduced, that this is happening on Firefox too ... so I think this is not a browser-specific problem. @skjnldsv What do you think? Is it easy to fix this? 😅

Maybe together with: #7492

bildschirmfoto 2017-12-13 um 17 11 01

MariusBluem added a commit that referenced this issue Dec 13, 2017
@MariusBluem
Try fixing #5337 based on Morris' feedback
80cb6e4 
Signed-off-by: Marius Blüm <[email protected]>
@MariusBluem MariusBluem mentioned this issue Dec 13, 2017
Closed
@skjnldsv
Copy link
Member

Disable the gallery app. :)

@MariusBluem
Copy link
Member Author

Disable the gallery app. :)

Not really 😱 This did work :D

@MorrisJobke
Copy link
Member

Right - I was wrong - it is this part:

https://github.com/nextcloud/gallery/blob/3618fc1a28fd9ae064bb157703eb0ef878789d35/css/share.css#L61-L67

@skjnldsv
Copy link
Member

Sorry I was late to the party! 😆

@skjnldsv
Copy link
Member

Fixed already

@skjnldsv skjnldsv mentioned this issue Feb 23, 2018
Merged
@skjnldsv
Copy link
Member

Oups, nope, I tought it was!

Fix in nextcloud/gallery#399

@skjnldsv skjnldsv reopened this Feb 23, 2018
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Feb 23, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Feb 24, 2018
@MorrisJobke
Copy link
Member

Fixed in master and will be backported to 13.

@nextcloud-bot nextcloud-bot mentioned this issue Sep 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: sharing good first issue Small tasks with clear documentation about how and in which place you need to fix things in. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging a pull request may close this issue.

Try fixing #5337 based on Morris' feedback nextcloud/server
4 participants
@MorrisJobke @jancborchardt @skjnldsv @MariusBluem