fix: Change scroll container for sharing details

[juliusknorr]

Fix #41421
Fix #41304
Replaces #41424

Best to be reviewed without whitespace changes https://github.com/nextcloud/server/pull/41444/files?w=1 as I introduce one wrapping container for the new scroll area

[nfebe]

It's better for the white space changes to first have commit followed by the actual change.

[juliusknorr]

It's better for the white space changes to first have commit followed by the actual change.

Hm, I don't see a point in that, can you elaborate what the benefit would be? To me having one atomic change with all required adjustemnts seems more reasonable.

[ShGKme]

@juliushaertl Do you have understanding, what property and why fixes the problem with the scrolling?
Why there is a large padding in Julia's PR.

[nfebe]

Hm, I don't see a point in that, can you elaborate what the benefit would be? To me having one atomic change with all required adjustemnts seems more reasonable.

It's confusing for me now and it would definitely be more confusing in future if anyone looks at the commit. The fix says "Change scroll container for sharing details" then the diff shows bunch for white space changes.

Unless I am missing something, I think it would be okay if the formatting changes only affected the areas that need to be reviewed. Otherwise, what if aside actual functional tests something is introduced in the unconcerned sections.

That said, given, there no strict commit culture here at Nextcloud, it would be helpful then to highlight the actual changes via comment or something or best in my opinion, separate the commits (for this and similar kind of changes in the future).

[nfebe]

Tested works....

[juliusknorr]

It's confusing for me now and it would definitely be more confusing in future if anyone looks at the commit. The fix says "Change scroll container for sharing details" then the diff shows bunch for white space changes.

Unless I am missing something, I think it would be okay if the formatting changes only affected the areas that need to be reviewed. Otherwise, what if aside actual functional tests something is introduced in the unconcerned sections.

That said, given, there no strict commit culture here at Nextcloud, it would be helpful then to highlight the actual changes via comment or something or best in my opinion, separate the commits (for this and similar kind of changes in the future).

Right, thanks for elaborating. This should be mostly relevant when running git blame where the -w -M flags are quite useful generally. I'd for now just extend the commit message to take the large whitespace change into account then.

[juliusknorr]

/compile

[juliusknorr]

Do you have understanding, what property and why fixes the problem with the scrolling?
Why there is a large padding in Julia's PR.

I think the main lacking part was setting position: relative; on all wrapping containers as otherwise the flexbox would exceed the height even with enforcing 100%. The extra bottom margin was also a bit of a mystery to me tough.

[jancborchardt]

Just one detail @juliushaertl – the "Delete share" button is not supposed to be sticky, but the last button in the content area. As proposed by @JuliaKirschenheuter and approved by Michael in #41304 (comment)