Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV]: Move delete share button into the scrolling container #41463

Closed
juliusknorr opened this issue Nov 14, 2023 · 6 comments · Fixed by #41489
Closed

[BITV]: Move delete share button into the scrolling container #41463

juliusknorr opened this issue Nov 14, 2023 · 6 comments · Fixed by #41489
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug
Milestone

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Nov 14, 2023

Just one detail @juliushaertl – the "Delete share" button is not supposed to be sticky, but the last button in the content area. As proposed by @JuliaKirschenheuter and approved by Michael in #41304 (comment)

Originally posted by @jancborchardt in #41444 (comment)

@juliusknorr juliusknorr changed the title Just one detail @juliushaertl – the "Delete share" button is not supposed to be sticky, but the last button in the content area. As proposed by @JuliaKirschenheuter and approved by Michael in https://github.com/nextcloud/server/issues/41304#issuecomment-1808090609 Move delete share button into the scrolling container Nov 14, 2023
@juliusknorr juliusknorr added bug 1. to develop Accepted and waiting to be taken care of labels Nov 14, 2023
@juliusknorr
Copy link
Member Author

@jancborchardt @JuliaKirschenheuter Is this critical for the review or just polishing?

@jancborchardt
Copy link
Member

@juliushaertl don't know if it's critical for the review – it's a regression of behavior though, and as @AndyScherzinger also noted on mobile leads to a very small or overlapped scroll area.

@JuliaKirschenheuter
Copy link
Contributor

JuliaKirschenheuter commented Nov 14, 2023

and as @AndyScherzinger also noted on mobile leads to a very small or overlapped scroll area.

Yes, critical

Viewport: 1280px + 400% zoom

Screenshot from 2023-11-14 09-44-19

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Nov 14, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the title Move delete share button into the scrolling container [BITV]: Move delete share button into the scrolling container Nov 14, 2023
@JuliaKirschenheuter
Copy link
Contributor

Viewport: 1280px + 400% zoom

will be moved to another issue

@ShGKme
Copy link
Contributor

ShGKme commented Nov 15, 2023

Viewport: 1280px + 400% zoom

Is there a problem? The requirement for 400% Zoom and 320px viewport was only about width, not height

@JuliaKirschenheuter
Copy link
Contributor

will be moved to another issue

#41504

@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants