40172 Polish new sharing flow : accesibility, expand bahavior, click outside behaviour #40266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
changed the title
|
/compile amend / |
nextcloud-command
force-pushed
the
40172-polish-new-sharing-flow
branch
from
6bb4e5c
to
ad17781
Compare
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
from
ad17781
to
4490340
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
40172-polish-new-sharing-flow
branch
from
4490340
to
486ed0f
Compare
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
from
486ed0f
to
ab9a304
Compare
|
/backport to stable27 |
artonge
reviewed
Sep 6, 2023
apps/files_sharing/src/components/SharingEntryQuickShareSelect.vue
Outdated
Show resolved
Hide resolved
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
from
ab9a304
to
85280f6
Compare
juliusknorr
approved these changes
Sep 6, 2023
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
from
85280f6
to
7ec3d02
Compare
|
/compile amend / |
AndyScherzinger
approved these changes
Sep 6, 2023
nextcloud-command
force-pushed
the
40172-polish-new-sharing-flow
branch
from
7ec3d02
to
3b0bf0f
Compare
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
2 times, most recently
from
8226964
to
258f5eb
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
40172-polish-new-sharing-flow
branch
from
258f5eb
to
f246b78
Compare
Currently, swithcing between permissions in the sharing permissions details view would toggle the custom permissions view. We think, it's better for the custom permission option to simple expand the custom permissions view and never close it gain even if the user is switching between bundled permissions. The user can always collapse the view by using the "Advanced settings" toggle. Signed-off-by: fenn-cs <[email protected]>
If a user clicks anywhere outside of the quickshare dropdown, it should be closed. Signed-off-by: fenn-cs <[email protected]>
- Adds appropriate aria attributes - Uses button element for dropdown items as it's more semantically correct - Uses trap-focus lib to trap focus when the drowpdown is active - Adds custom handling for arrow up and down Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
40172-polish-new-sharing-flow
branch
from
f246b78
to
faa76b9
Compare
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following issues
#39472 (comment)
Share list
BUG: Quick access menu should close when click outside
BUG: Create a new share to a user, change to custom permission, click save share, go back to the share details -> now update and share check-boxes are missing (the custom permissions are the same as view only, but nevertheless the check-boxes should of course still be available)
Non-blocking
Follow-ups:
Resolves : #40172