⛑️ Polishing for new sharing design and flow 🤝

[AndyScherzinger]

Follow-up to #26691 listing the remaining open issues to be fixed in master as well as stable27

---

#39472 (comment)

Share list

• BUG: Quick access menu should close when click outside

Bugs specific to share settings

• BUG: Setting "Allow public upload" disabled should also disable options to set file drop, according permissions

• BUG: Lots of optional share settings for the ones that should affect front-end:
  • BUG: Public upload can be blocked
• BUG: Custom permissions should show permissions in subline #40289

---

• BUG: [Bug]: Cannot leave share from conversation #40228 - Edit (louis): seem unrelated
• BUG: [Bug]: Unable to invite guest #40299

---

• BUG: Create a new share to a user, change to custom permission, click save share, go back to the share details -> now update and share check-boxes are missing (the custom permissions are the same as view only, but nevertheless the check-boxes should of course still be available)
• BUG: Creating shares should probably not reload the full file list. Edit (louis): only an issue with 27 as the logic to handle share changes is not fine-grained enough to only refresh the share status of a file. Also, it was not introduced by the new sharing flow.
• BUG: Related resources should not appear in the share details view - Hide additional content when share details is open #40365

Non-blocking

• Accessibility fixes for quick menu
• "Delete share" button does not need to be sticky, can just be a tertiary button (no background by default) below the advanced settings toggle (not inside advanced settings)
• The "Cancel" and primary button on the bottom need a backdrop to separate them a bit from the background, best a fade from color-main-background on the bottom to transparent on the top.
• Currently links are sorted below emails once created, but sorting should be: Links, mails, users
• Too many share saved/updated notifications when updating/creating shares
• QA: Needs side by side testing if all old options are possible or also properly limited with the new one
• Clarify how to handle tests, currently most (if not all) e2e tests in selenium would become obsolete, should probably be followed up by cypress tests #40436
• If allow public upload admin setting is unchecked we should rename "Allow upload and editing" to "allow editing" and file drop / create permission should be disabled state

---

#39472 (review)

Follow-ups:

• Switching between permissions presets should not close the advanced settings view
• The content of the sidebar is scroll-able when it should only be the content of the share tab

UI comments:

• Button at the bottom of the details view should not move when scrolling to the bottom
• "Delete share" button text seems smaller than other buttons
• It is confusing to have the download permission under "Custom permissions" as it is not taken into account for bundles

[AndyScherzinger]

It is confusing to have the download permission under "Custom permissions" as it is not taken into account for bundles

@artonge can you elaborate on this item, what is meant by it?

[nfebe]

This was closed automatically, reopening to all boxes are checked.

[AndyScherzinger]

@fenn-cs better to move the remaining items to a new issue and close this one. The closed ones are resolved with 27.1.0 the remaining ones would then be 27.1.1 and the ticket can't reflect that when not split up 😊

[sorbaugh]

@AndyScherzinger on it

[AndyScherzinger]

remaining items have been moved to #40438 as a follow-up issue