Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ocp): Add types and strict typing to \OCP\Group\IGroup #38425

Merged
merged 1 commit into from
Nov 2, 2023
Merged

feat(ocp): Add types and strict typing to \OCP\Group\IGroup #38425

merged 1 commit into from
Nov 2, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 23, 2023 •
edited
Loading

Summary

Side quest while working on #38423

TODO

  • Add parameter types
  • Add return types
  • Enable strict types
  • Adjust implementation

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone May 23, 2023
@ChristophWurst ChristophWurst requested a review from a team May 23, 2023 17:02
@ChristophWurst ChristophWurst self-assigned this May 23, 2023
@ChristophWurst ChristophWurst requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a team May 23, 2023 17:02
@ChristophWurst ChristophWurst requested review from a team, ArtificialOwl and icewind1991 and removed request for ArtificialOwl, icewind1991 and a team May 30, 2023 14:52
@ChristophWurst
Copy link
Member Author

nvm thought the reassignment would give new reviewers

@ChristophWurst
Copy link
Member Author

@ArtificialOwl @fenn-cs @icewind1991 please give this a review

@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jun 15, 2023
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 15, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@ChristophWurst ChristophWurst merged commit d779092 into master Nov 2, 2023
37 checks passed
@ChristophWurst ChristophWurst deleted the feat/ocp/strict-igroup branch November 2, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@rullzer rullzer rullzer approved these changes

@nfebe nfebe Awaiting requested review from nfebe nfebe was automatically assigned from nextcloud/server-backend

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement pending documentation This pull request needs an associated documentation update
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@ChristophWurst @rullzer @icewind1991 @susnux