-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(carddav): Check enumeration settings for all SAB methods #38423
Merged
ChristophWurst
merged 1 commit into
master
from
fix/carddav/check-system-address-book-enumeration
May 25, 2023
Merged
fix(carddav): Check enumeration settings for all SAB methods #38423
ChristophWurst
merged 1 commit into
master
from
fix/carddav/check-system-address-book-enumeration
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
2. developing
Work in progress
feature: dav
feature: carddav
Related to CardDAV internals
labels
May 23, 2023
8 tasks
ChristophWurst
commented
May 23, 2023
/backport to stable27 |
ChristophWurst
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
May 24, 2023
nickvergessen
requested changes
May 24, 2023
7 tasks
nickvergessen
approved these changes
May 24, 2023
AndyScherzinger
approved these changes
May 24, 2023
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
force-pushed
the
fix/carddav/check-system-address-book-enumeration
branch
from
May 25, 2023 07:11
546e5fe
to
5cfbd4c
Compare
JohannesGGE
approved these changes
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested the group restriction. Works 💯
ChristophWurst
deleted the
fix/carddav/check-system-address-book-enumeration
branch
May 25, 2023 08:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The system address book has to repsect sharing enumeration settings in all code paths.
TODO
How to test
curl -k https://localhost/remote.php/dav/addressbooks/users/user1/z-server-generated--system/Database:user2.vcf -u user1:password1
-> downloads user2.vcf on master and this branch.curl -k https://localhost/remote.php/dav/addressbooks/users/user1/z-server-generated--system/Database:user3.vcf -u user1:password1
-> downloads user3.vcf on master, Forbidden error here.Checklist