Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(carddav): Check enumeration settings for all SAB methods #38423

Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented May 23, 2023

Summary

The system address book has to repsect sharing enumeration settings in all code paths.

TODO

  • Fix checks

How to test

  1. Create user1:password1
  2. Create user2:password2
  3. Create user3:password3
  4. Create group1 and assign user1 and user2
  5. Create group2 and assign user1

curl -k https://localhost/remote.php/dav/addressbooks/users/user1/z-server-generated--system/Database:user2.vcf -u user1:password1 -> downloads user2.vcf on master and this branch.

curl -k https://localhost/remote.php/dav/addressbooks/users/user1/z-server-generated--system/Database:user3.vcf -u user1:password1 -> downloads user3.vcf on master, Forbidden error here.

Checklist

@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 23, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@blizzz blizzz mentioned this pull request May 24, 2023
10 tasks
@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst ChristophWurst marked this pull request as ready for review May 24, 2023 19:26
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 24, 2023
@ChristophWurst ChristophWurst force-pushed the fix/carddav/check-system-address-book-enumeration branch from 546e5fe to 5cfbd4c Compare May 25, 2023 07:11
Copy link
Contributor

@JohannesGGE JohannesGGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the group restriction. Works 💯

@ChristophWurst ChristophWurst merged commit b6d7343 into master May 25, 2023
@ChristophWurst ChristophWurst deleted the fix/carddav/check-system-address-book-enumeration branch May 25, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: carddav Related to CardDAV internals feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants