Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make grid view button sticky #37895

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Apr 23, 2023

Summary

Before After
Screencast from 2023-04-23 21-25-52.webm Screencast from 2023-04-23 21-30-30.webm

Please ignore the weird "x" at the end. I opened the sidebar but stopped the screen recording too fast.

TODO

  • ...

Checklist

Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb requested review from a team, skjnldsv, Pytal and szaimen and removed request for a team April 23, 2023 19:35
@kesselb kesselb added bug 3. to review Waiting for reviews labels Apr 23, 2023
@kesselb kesselb requested a review from solracsf April 23, 2023 19:43
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my testing, thanks for fixing this! :)

Minor pic: some elements in the background seem to shine through:
image

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 24, 2023
@szaimen szaimen merged commit 51aa9e6 into master Apr 24, 2023
@szaimen szaimen deleted the fix-make-grid-toggle-sticky branch April 24, 2023 09:43
@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable26

@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable25

@kesselb
Copy link
Contributor Author

kesselb commented Apr 24, 2023

Minor pic: some elements in the background seem to shine through:

True. If you look carefully at your screenshot, it's also visible next to the plus button.
I had a look and opacity 0.5 is the issue here. We need a real frontender to fix this one. ;)

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable26

@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin/stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@kesselb kesselb mentioned this pull request Apr 24, 2023
5 tasks
@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin/stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Show Grid view or Show List View dissapear on scroll (expected to be sticky)
3 participants