Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Handle reminders where calendar name is null #37769

Merged
merged 1 commit into from
May 17, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 17, 2023

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #36217

@tcitworld tcitworld self-requested a review April 18, 2023 06:58
@tcitworld tcitworld self-assigned this Apr 18, 2023
@skjnldsv skjnldsv mentioned this pull request Apr 18, 2023
7 tasks
This adds an interface change, but that's not a public API.

We're handling this in the providers and not in ReminderService because
the fallback is translated with the user's language.

Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld marked this pull request as ready for review April 21, 2023 08:26
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport fixed

@ChristophWurst ChristophWurst added the 4. to release Ready to be released and/or waiting for tests to finish label Apr 21, 2023
@blizzz blizzz mentioned this pull request May 16, 2023
@blizzz blizzz merged commit bf71686 into stable25 May 17, 2023
@blizzz blizzz deleted the backport/36217/stable25 branch May 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants