Handle reminders where calendar name is null #36217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
bug
3. to review
This adds an interface change, but that's not a public API. We're handling this in the providers and not in ReminderService because the fallback is translated with the user's language. Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
handle-push-notification-with-no-calendar-name
branch
from
4dc068b
to
62739ec
Compare
ChristophWurst
approved these changes
Jan 18, 2023
|
/backport to stable25 |
come-nc
approved these changes
Jan 20, 2023
miaulalala
approved these changes
Jan 23, 2023
Merged
Merged
Merged
|
Drone failure unrelated |
1 task
|
/backport to stable26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an interface change, but that's not a public API. Backports should be acceptable, unless the new string to translate is not.
We're handling this in the providers and not in ReminderService because the fallback is translated with the user's language.
Checklist