Allow target="_blank" in apps navigation items #35667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
artonge,
skjnldsv and
Pytal
and removed request for
a team
|
/compile amend / |
CarlSchwan
approved these changes
Dec 8, 2022
nextcloud-command
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
802fd57
to
e04d042
Compare
skjnldsv
approved these changes
Dec 8, 2022
skjnldsv
added
4. to release
artonge
approved these changes
Dec 8, 2022
|
conflicts :( |
|
/compile amend / |
nextcloud-command
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
e04d042
to
a54d82b
Compare
|
@tcitworld needs manual rebase |
nextcloud-command
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
a54d82b
to
e97ef64
Compare
tcitworld
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
e97ef64
to
bb6de2a
Compare
skjnldsv
changed the title
nickvergessen
approved these changes
Jan 4, 2023
|
Conflicting files :( There are quite some PRs in the queue atm. |
tcitworld
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
bb6de2a
to
ef2ccfc
Compare
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
allow-target-blank-in-app-navigation
branch
from
ef2ccfc
to
5bcc277
Compare
|
Manual backport in #36007 |
|
The backport to stable25 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79
Checklist