Move app menu to vue #33728

juliusknorr · 2022-08-28T19:25:04Z

Move app menu to vue in preparation for further adjustments of #33568

Fix current app indicator
Properly fix resizing
Notification indicator in actions menu
Aria-label on more apps button
Move to bar active indicator as discussed with @jancborchardt
Fix focus frame

Screen.Recording.2022-08-29.at.19.25.07.mov

core/src/components/AppMenu.vue

CarlSchwan · 2022-08-29T10:54:28Z

The focus frame is now touching the border of the header, causing some contrast issue since there is no clear separation between the focus frame and outside the focus frame.

szaimen · 2022-08-29T11:00:30Z

@juliushaertl would it be possible to add an API for re-ordering the apps or hiding some of them? I am thinking about the apporder app that will probably break after this PR...

juliusknorr · 2022-08-29T16:47:19Z

@juliushaertl would it be possible to add an API for re-ordering the apps or hiding some of them? I am thinking about the apporder app that will probably break after this PR...

Possible yes, but not planned yet. There is some long discussion about this in #4917

juliusknorr · 2022-08-29T17:26:04Z

@CarlSchwan Addressed :)

core/src/components/AppMenu.vue

PVince81 · 2022-08-31T09:46:46Z

there are JS test failures related to snap/snapper that need to be adjusted
maybe we changed the width?

Signed-off-by: Daniel Calviño Sánchez <[email protected]>

juliusknorr · 2022-08-31T11:08:04Z

Thanks @danxuliu ❤️

jancborchardt

Some details:

The active indicator is a bit low down, would be nice if it’s visually inbetween the icon and the content. Just a few px further up :)
With a light background selected from the Dashboard, is the same logic of making the header bar icons dark, so they are visible?
As per the video, the focus effect is still overlapping the text, or is the vid outdated, as in @CarlSchwan’s comment it also looked different?

juliusknorr · 2022-08-31T12:24:02Z

With a light background selected from the Dashboard, is the same logic of making the header bar icons dark, so they are visible?

Something we can do once the background image is a global option: #33733

As per the video, the focus effect is still overlapping the text, or is the vid outdated, as in @CarlSchwan’s comment it also looked different?

I didn't touch that yet, to first get the major change in, still tracked as open in #33741

The active indicator is a bit low down, would be nice if it’s visually inbetween the icon and the content. Just a few px further up :)

Will adjust.

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr · 2022-08-31T12:39:40Z

@jancborchardt

szaimen · 2022-08-31T12:42:08Z

core/src/init.js

@@ -36,7 +36,8 @@ import { setUp as setUpMainMenu } from './components/MainMenu'
 import { setUp as setUpUserMenu } from './components/UserMenu'
 import PasswordConfirmation from './OC/password-confirmation'

-const breakpointMobileWidth = getComputedStyle(document.documentElement).getPropertyValue('--breakpoint-mobile')
+// keep in sync with core/css/variables.scss
+const breakpointMobileWidth = 1024


not sure about this... yet another place where we need to maintain this number...

This is breaking the jsunit tests it seems, so I only reverted to the previous state. Something to look into at some later point.

jancborchardt

Looks super nice! :)

juliusknorr · 2022-08-31T14:16:57Z

Failure unrelated

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: nextcloud-command <[email protected]>

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

Which was removed in the Vue rewrite in nextcloud#33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: Akhil <[email protected]>

juliusknorr added enhancement 2. developing Work in progress labels Aug 28, 2022

juliusknorr mentioned this pull request Aug 28, 2022

⚗️ Proof of concept: Redesign app-content #33568

Merged

32 tasks

juliusknorr commented Aug 28, 2022

View reviewed changes

core/src/components/AppMenu.vue Outdated Show resolved Hide resolved

juliusknorr force-pushed the enh/app-menu-vue branch from b4a0796 to 1721afe Compare August 29, 2022 07:10

juliusknorr requested review from a team, PVince81, Pytal, szaimen, skjnldsv, CarlSchwan and artonge and removed request for a team August 29, 2022 07:20

juliusknorr added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 29, 2022

juliusknorr added this to the Nextcloud 25 milestone Aug 29, 2022

juliusknorr requested a review from jancborchardt August 29, 2022 07:21

juliusknorr mentioned this pull request Aug 29, 2022

Design update #33736

Closed

64 tasks

juliusknorr force-pushed the enh/app-menu-vue branch from 95b1f88 to ffc251b Compare August 29, 2022 17:24

PVince81 mentioned this pull request Aug 29, 2022

[BITV] Header bar a11y issues #33741

Closed

8 tasks

artonge reviewed Aug 30, 2022

View reviewed changes

core/src/components/AppMenu.vue Outdated Show resolved Hide resolved

blizzz mentioned this pull request Aug 30, 2022

25.0.0 beta 4 #33762

Merged

juliusknorr force-pushed the enh/app-menu-vue branch from eed160f to ca43271 Compare August 30, 2022 20:06

juliusknorr requested a review from artonge August 30, 2022 20:07

artonge approved these changes Aug 31, 2022

View reviewed changes

skjnldsv approved these changes Aug 31, 2022

View reviewed changes

juliusknorr added the 4. to release Ready to be released and/or waiting for tests to finish label Aug 31, 2022

Adjust acceptance tests to changes in app menu

ac2d885

Signed-off-by: Daniel Calviño Sánchez <[email protected]>

jancborchardt requested changes Aug 31, 2022

View reviewed changes

juliusknorr added 2 commits August 31, 2022 14:36

Fix jsunit failures

aa85e1c

Signed-off-by: Julius Härtl <[email protected]>

Fix active app indicator position

ad8fadf

Signed-off-by: Julius Härtl <[email protected]>

juliusknorr requested a review from jancborchardt August 31, 2022 12:39

szaimen reviewed Aug 31, 2022

View reviewed changes

jancborchardt approved these changes Aug 31, 2022

View reviewed changes

CarlSchwan approved these changes Aug 31, 2022

View reviewed changes

juliusknorr merged commit b617f39 into master Aug 31, 2022

juliusknorr deleted the enh/app-menu-vue branch August 31, 2022 14:17

nickvergessen mentioned this pull request Oct 18, 2022

Fix rebuild navigation #34650

Merged

tcitworld added a commit that referenced this pull request Dec 8, 2022

Allow target="_blank" in app navigation items

802fd57

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

tcitworld mentioned this pull request Dec 8, 2022

Allow target="_blank" in apps navigation items #35667

Merged

4 tasks

tcitworld added a commit that referenced this pull request Jan 4, 2023

Allow target="_blank" in app navigation items

bb6de2a

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

tcitworld added a commit that referenced this pull request Jan 4, 2023

Allow target="_blank" in app navigation items

ef2ccfc

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

nickvergessen pushed a commit that referenced this pull request Jan 5, 2023

Allow target="_blank" in app navigation items

56c5273

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

nickvergessen pushed a commit that referenced this pull request Jan 5, 2023

Allow target="_blank" in app navigation items

23f9dd3

Which was removed in the Vue rewrite in #33728. This breaks things like nextcloud/external#79 Signed-off-by: Thomas Citharel <[email protected]>

nickvergessen mentioned this pull request Jan 5, 2023

[stable25] Allow target="_blank" in app navigation items #36007

Merged

juliusknorr mentioned this pull request Apr 24, 2023

Not working with NC25 juliusknorr/apporder#112

Closed

2 tasks

joshtrichards mentioned this pull request Jan 31, 2024

Vue apps menu #15585

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move app menu to vue #33728

Move app menu to vue #33728

juliusknorr commented Aug 28, 2022 •

edited

Loading

CarlSchwan commented Aug 29, 2022

szaimen commented Aug 29, 2022

juliusknorr commented Aug 29, 2022

juliusknorr commented Aug 29, 2022

PVince81 commented Aug 31, 2022

juliusknorr commented Aug 31, 2022

jancborchardt left a comment •

edited by juliusknorr

Loading

juliusknorr commented Aug 31, 2022

juliusknorr commented Aug 31, 2022

szaimen Aug 31, 2022

juliusknorr Aug 31, 2022 •

edited

Loading

jancborchardt left a comment

juliusknorr commented Aug 31, 2022

Move app menu to vue #33728

Move app menu to vue #33728

Conversation

juliusknorr commented Aug 28, 2022 • edited Loading

CarlSchwan commented Aug 29, 2022

szaimen commented Aug 29, 2022

juliusknorr commented Aug 29, 2022

juliusknorr commented Aug 29, 2022

PVince81 commented Aug 31, 2022

juliusknorr commented Aug 31, 2022

jancborchardt left a comment • edited by juliusknorr Loading

Choose a reason for hiding this comment

juliusknorr commented Aug 31, 2022

juliusknorr commented Aug 31, 2022

szaimen Aug 31, 2022

Choose a reason for hiding this comment

juliusknorr Aug 31, 2022 • edited Loading

Choose a reason for hiding this comment

jancborchardt left a comment

Choose a reason for hiding this comment

juliusknorr commented Aug 31, 2022

juliusknorr commented Aug 28, 2022 •

edited

Loading

jancborchardt left a comment •

edited by juliusknorr

Loading

juliusknorr Aug 31, 2022 •

edited

Loading