fix reading newly written encrypted files before their cache entry is written #34724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
PVince81,
blizzz and
CarlSchwan
and removed request for
a team
CarlSchwan
approved these changes
Oct 21, 2022
PVince81
reviewed
Oct 21, 2022
icewind1991
force-pushed
the
encryption-read-before-cache
branch
from
f972374
to
2a2d3e2
Compare
|
encryption tests are failing |
PVince81
added
2. developing
… written Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encryption-read-before-cache
branch
from
2a2d3e2
to
bfc2bb3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
encryption-read-before-cache
branch
from
bfc2bb3
to
32840f1
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
encryption-read-before-cache
branch
from
32840f1
to
e3a0e64
Compare
PVince81
added
4. to release
|
sounds a bit similar to #25768 |
|
/backport to stable25 |
|
The backport to stable25 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep track of which files we know are encrypted so we know to decrypt them even if they are not in the cache.
This fixes an interaction with
files_accesscontrolwhere it tried to check the mimetype before the item was added to cache, resulting in it always detecting the mimetype asapplication/octet-stream(note that in a later step the mimetype was detected properly)To test:
application/octet-stream