Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[24] fix updating size when folder is empty #33562

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[24] fix updating size when folder is empty #33562

merged 1 commit into from
Aug 17, 2022

Conversation

icewind1991
Copy link
Member

To test:

  • Create an empty folder
  • Upload something into it
  • Check the folder size
  • Delete the file in the folder
  • Check the folder size again

Master version has been added to #32943

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 16, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24.0.5 milestone Aug 16, 2022
@icewind1991 icewind1991 requested review from danxuliu, a team, PVince81, ArtificialOwl and skjnldsv and removed request for a team August 16, 2022 11:43
@icewind1991 icewind1991 mentioned this pull request Aug 16, 2022
Closed
danxuliu
danxuliu approved these changes Aug 16, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@icewind1991 icewind1991 merged commit ba606f1 into stable24 Aug 17, 2022
@icewind1991 icewind1991 deleted the empty-folder-size-24 branch August 17, 2022 09:13
@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24.0.5
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @skjnldsv @danxuliu