-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for getting folder sizes #33484
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
Merged
Should be fixed with #33562 |
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration tests pass in latest 23 (v23.0.8rc1), but fail in latest master and 24. Due to that this pull request is kept as Developing until that is clarified.
These are the regressions:
Storage stats size after deleting the last file in a folder is wrong in 24, but not in master. The breaking PR in 24 was [24] store unencrypted size in the unencrypted_size column #32708, which is a backport of store unencrypted size in the unencrypted_size column #31966 without interface changes. Due to the interface changes 32708 is going to be reverted and replaced by Revert interface changes from "store unencrypted size in the unencrypted_size column" #32943, which also makes the integration tests fail.- Fixed in latest Revert interface changes from "store unencrypted size in the unencrypted_size column" #32943 and [24] fix updating size when folder is empty #33562If the tests are run in older commits note that
getstoragestats.php
may need to be used infeatures/bootstrap/Files.php
instead of justgetstoragestats
(see #32962, #33113 and #33116).@PVince81 @icewind1991