feature: use the viewer to render single file shares #33347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
feature/use-viewer-for-singe-file-shares
branch
2 times, most recently
from
f292125
to
38503ed
Compare
max-nextcloud
force-pushed
the
feature/use-viewer-for-singe-file-shares
branch
from
38503ed
to
c2c796f
Compare
max-nextcloud
force-pushed
the
feature/use-viewer-for-singe-file-shares
branch
from
c2c796f
to
98a3fef
Compare
max-nextcloud
force-pushed
the
feature/use-viewer-for-singe-file-shares
branch
2 times, most recently
from
fafb98f
to
523780a
Compare
Merged
PVince81
reviewed
Aug 17, 2022
Merged
Merged
|
/rebase |
|
triggered a rebase to bump CI |
PVince81
added
4. to release
Signed-off-by: Max <[email protected]>
Also bring back the text fallback Signed-off-by: Max <[email protected]>
Only render images and videos with the viewer. Text has its own way of handling single file shares for now. In case viewer does not support the file format fall back to the old way of handling single file shares. Signed-off-by: Max <[email protected]>
nextcloud-command
force-pushed
the
feature/use-viewer-for-singe-file-shares
branch
from
523780a
to
b67aaf7
Compare
CarlSchwan
approved these changes
Aug 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some issues with positioning and sizing of the image and video.