You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With nextcloud/server#33347 and nextcloud/viewer#1242 the viewer will be used to open single shared files. Text still has its own handling in src/public.js. Using the viewer to open the file just like we do in other places seems like the more generic approach.
Using the viewer as is does not work right now mainly due to css style issues. The text editor will have a hight of 0 and therefore not be visible. There's also other side effects of the surrounding page such as text-align: center that need to be accounted for.
The text was updated successfully, but these errors were encountered:
It would be nice if we could either broaden that condition to also open things text handles or remove it entirely.
For now if we removed it the file would be opened twice:
once by the server code calling viewer.open(...)
once by our own code in src/public.js
The servers viewer.open(...) will open the file inside the page itself rather than in a modal. Quite a bit of our styles still depend on being opened in a modal.
So in order to get this to work here's what i'd try:
add the mimetype to the list in server - markdown for example
prevent src/public.js from loading the file as well so we do not open it twice
take a look at the result and adjust the css and maybe html until it works properly.
With nextcloud/server#33347 and nextcloud/viewer#1242 the viewer will be used to open single shared files. Text still has its own handling in
src/public.js
. Using the viewer to open the file just like we do in other places seems like the more generic approach.Using the viewer as is does not work right now mainly due to css style issues. The text editor will have a hight of 0 and therefore not be visible. There's also other side effects of the surrounding page such as
text-align: center
that need to be accounted for.The text was updated successfully, but these errors were encountered: