Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS unit test execution #33

Merged
merged 1 commit into from
Jun 13, 2016
Merged

Add JS unit test execution #33

merged 1 commit into from
Jun 13, 2016

Conversation

LukasReschke
Copy link
Member

Let's see… 🙈

@LukasReschke LukasReschke added this to the Nextcloud 10 milestone Jun 9, 2016
@LukasReschke
Copy link
Member Author

Okay. @MorrisJobke needs to adjust the Docker 😉

@MorrisJobke MorrisJobke self-assigned this Jun 10, 2016
@LEDfan
Copy link
Member

LEDfan commented Jun 10, 2016

I locally played a bit with it (using the Drone CLI (http://readme.drone.io/devs/cli/#local-testing:b659b046131d4024ab5e2d3675716bf0) and I think this Dockerfile should work:

FROM debian
RUN apt-get update && apt-get install -y php5-intl php5-gd git curl \
    php5-cli php5-curl php5-imagick php5-pgsql php5-mcrypt php5-ldap \
    php5-apcu php5-redis php5-sqlite nodejs npm
RUN ln -s /usr/bin/nodejs /usr/bin/node # https://github.com/Medium/phantomjs/issues/157
ENV PHANTOMJS_BIN ./build/node_modules/phantomjs/bin/phantomjs
RUN php5enmod zip intl gd
RUN curl -O -L https://phar.phpunit.de/phpunit-4.8.24.phar \
    && chmod +x phpunit-4.8.24.phar \
    && mv phpunit-4.8.24.phar /usr/local/bin/phpunit

ADD nextcloud.ini /usr/local/etc/php/conf.d/nextcloud.ini

It only needs to install node en sets some paths correctly.

@MorrisJobke
Copy link
Member

It only needs to install node en sets some paths correctly.

Awesome :) I will try it :)

@MorrisJobke
Copy link
Member

I always get following error, where the execution then stucks:

WARN [plugin]: Error during loading "/drone/src/build/node_modules/karma-phantomjs-launcher" plugin:
  Cannot find module 'phantomjs-prebuilt'
INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
WARN [launcher]: Can not load "PhantomJS", it is not registered!
  Perhaps you are missing some plugin?

@LEDfan
Copy link
Member

LEDfan commented Jun 13, 2016

Mm. Looks like the NPM module phantomjs-prebuilt must be installed.

@MorrisJobke
Copy link
Member

Mm. Looks like the NPM module phantomjs-prebuilt must be installed.

I'm already on it :)

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jun 13, 2016
@MorrisJobke
Copy link
Member

PhantomJS 2.1.1 (Linux 0.0.0): Executed 799 of 802 (skipped 3) SUCCESS (11.328 secs / 11.015 secs)

\o/

@MorrisJobke
Copy link
Member

LGTM

1 similar comment
@blizzz
Copy link
Member

blizzz commented Jun 13, 2016

LGTM

@MorrisJobke MorrisJobke merged commit 0b2940e into master Jun 13, 2016
@MorrisJobke MorrisJobke deleted the LukasReschke-patch-1 branch June 13, 2016 12:18
@MorrisJobke
Copy link
Member

Let me port this to stable9 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants