UnifiedSearchController: strip webroot from URL before finding a route #28303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejo-
requested review from
nickvergessen,
icewind1991,
juliusknorr and
julien-nc
mejo-
force-pushed
the
fix/unifiedsearchcontroller_webroot
branch
from
f39e7f6
to
5e85577
Compare
mejo-
force-pushed
the
fix/unifiedsearchcontroller_webroot
branch
from
5e85577
to
5986863
Compare
kesselb
reviewed
Aug 5, 2021
mejo-
force-pushed
the
fix/unifiedsearchcontroller_webroot
branch
from
5986863
to
1fa67dc
Compare
skjnldsv
added
2. developing
mejo-
force-pushed
the
fix/unifiedsearchcontroller_webroot
branch
4 times, most recently
from
36cb050
to
02d9297
Compare
This should fix route matching in UnifiedSearchController on setups with Nextcloud in a subfolder (webroot). Fixes: #24144 Signed-off-by: Jonas Meurer <[email protected]>
Signed-off-by: Jonas Meurer <[email protected]>
mejo-
force-pushed
the
fix/unifiedsearchcontroller_webroot
branch
from
02d9297
to
7c76e85
Compare
|
Thanks for your comments @ChristophWurst! I applied all your suggested changes 😊 |
ChristophWurst
approved these changes
Aug 16, 2021
juliusknorr
approved these changes
Aug 16, 2021
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).
Fixes: #24144
Signed-off-by: Jonas Meurer [email protected]