Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

function findMatchingRoute doesn't support nextcloud hosted in subdirectory #24144

Closed
StCyr opened this issue Nov 15, 2020 · 5 comments · Fixed by #28303
Closed

function findMatchingRoute doesn't support nextcloud hosted in subdirectory #24144

StCyr opened this issue Nov 15, 2020 · 5 comments · Fixed by #28303
Labels
2. developing Work in progress bug

Comments

@StCyr
Copy link
Contributor

StCyr commented Nov 15, 2020

server/lib/private/Route/Router.php

Line 245 in 769f59e

public function findMatchingRoute(string $url): array {

function assumes nextcloud is always at the webroot. Could we change that?

for example by changing substr tests by strpos?

or by adding strpos tests after the substr tests, and before the final else clause?

That shouldn't be an issue if you have good unit tests :-)
@StCyr
Copy link
Contributor Author

StCyr commented Nov 15, 2020

Current behaviour causes issues like these: nextcloud/mail#4044

@skjnldsv skjnldsv added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Dec 30, 2020
@szaimen
Copy link
Contributor

szaimen commented Jun 18, 2021

cc @nextcloud/server-triage

@StCyr
Copy link
Contributor Author

StCyr commented Jun 20, 2021

If I can help....

mejo- added a commit that referenced this issue Jul 14, 2021
@mejo-
Strip webroot from URL before trying to find a route (Fixes: #24144)
2c7439b 
This should fix `Route\Router->findMatchingRoute()` on setups with
Nextcloud in a subfolder.
mejo- added a commit that referenced this issue Jul 14, 2021
@mejo-
Strip webroot from URL before trying to find a route (Fixes: #24144)
ce005aa 
This should fix `Route\Router->findMatchingRoute()` on setups with
Nextcloud in a subfolder.

Signed-off-by: Jonas Meurer <[email protected]>
@mejo- mejo- mentioned this issue Jul 14, 2021
Closed
@mejo-
Copy link
Member

mejo- commented Jul 14, 2021

I stumbled across this issue while debugging issue "Search does not include Page contents" in the Colectives app.

I opened a PR to fix this issue: #27971

@szaimen szaimen added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jul 14, 2021
mejo- added a commit that referenced this issue Aug 3, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
f39e7f6 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
@mejo- mejo- mentioned this issue Aug 3, 2021
Merged
@mejo-
Copy link
Member

mejo- commented Aug 3, 2021

So I went ahead and opened a new PR in order to fix this issue: #28303

Reviews welcome 😊

mejo- added a commit that referenced this issue Aug 3, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
5e85577 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
mejo- added a commit that referenced this issue Aug 4, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
5986863 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
mejo- added a commit that referenced this issue Aug 6, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
1fa67dc 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
mejo- added a commit that referenced this issue Aug 10, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
0e2b1fb 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
mejo- added a commit that referenced this issue Aug 10, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
83472e5 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
mejo- added a commit that referenced this issue Aug 16, 2021
@mejo-
UnifiedSearchController: strip webroot from URL before finding a route
5f5bacd 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 16, 2021
@mejo- @backportbot
UnifiedSearchController: strip webroot from URL before finding a route
c53fa3e 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 16, 2021
@mejo- @backportbot
UnifiedSearchController: strip webroot from URL before finding a route
57e20ed 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 16, 2021
@mejo- @backportbot
UnifiedSearchController: strip webroot from URL before finding a route
7ddfd4d 
This should fix route matching in UnifiedSearchController on setups with
Nextcloud in a subfolder (webroot).

Fixes: #24144
Signed-off-by: Jonas Meurer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2. developing Work in progress bug
Projects
None yet
Milestone
No milestone
4 participants
@mejo- @StCyr @skjnldsv @szaimen