-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to favorites not working in IE11 - polyfill needed #12007
Comments
Workaround: Add the following polyfill to core/js/js.js: |
would you like to create a pull request for this? |
Woah now, that thing I posted was just a workaround, definitely not a fix! I have no idea what that core/js/js.js is and if it actually solves all instances of this bug. I'd guess that there is a more official way to do this. Sure it might be that my workaround works accidentally but that doesn't seem like a very methodical way of approaching, surely there is some logic to what javascript goes in to what file and how are they processed, is there not? I would have to examine the source very carefully to create a maintainable and elegant solution to actually create a PR that I would be confident in supporting. If the authors agree, go for it, but I stress again that that file was a random guess that happened to work. |
@Req you are very welcome to create a more proper fix for this |
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Steps to reproduce 1
Steps to reproduce 2
Expected behaviour
File is added to favorites
Actual behaviour
File not added to favorites, developer console shows error that object does not support startsWith (merged-index.js 8270,3)
Server configuration
Ubuntu 18, Apache2, PostgreSQL, PHP 7
Nextcloud version: 14.0.1
Fresh install
Where did you install Nextcloud from: downloaded from website
http://example.com/index.php/settings/integrity/failed : No errors have been found
List of activated apps:
Enabled:
Disabled:
Nextcloud configuration:
{
"system": {
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"256.256.256.256",
"foo.example.org"
],
"datadirectory": "REMOVED SENSITIVE VALUE",
"dbtype": "pgsql",
"version": "14.0.1.1",
"overwrite.cli.url": "http://1.1.1.1",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"default_language": "fi",
"updater.release.channel": "production",
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_smtpmode": "smtp",
"mail_smtpauthtype": "LOGIN",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtpauth": 1,
"mail_smtphost": "REMOVED SENSITIVE VALUE",
"mail_smtpport": "587",
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE"
}
}
Are you using external storage, if yes which one: Files are on local disk
Are you using encryption: no
Client configuration
Browser: IE 11.354.17134.0
Operating system: Windows 10
Logs
Web server error log
clear
Nextcloud log (data/nextcloud.log)
clear
Browser log
Console: object does not support startsWith (merged-index.js 8270,3)
You know the error that I mean - I only have a picture of the error and it's in finnish but you know the one. You'll just need a polyfill.
The text was updated successfully, but these errors were encountered: