Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon-white class doesn't work on IE11 #8702

Closed
juliusknorr opened this issue Mar 7, 2018 · 3 comments · Fixed by #10311
Closed

icon-white class doesn't work on IE11 #8702

juliusknorr opened this issue Mar 7, 2018 · 3 comments · Fixed by #10311
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Milestone

Comments

@juliusknorr
Copy link
Member

Since IE11 is still supported we cannot use the .icon-white class as added in #7319, since filter:invert(100%); is not supported: https://caniuse.com/#search=invert

A possible solution would be to use something like https://github.com/shekhardesigner/InvertImages to provide a fallback solution for IE11. We could even simplify the script a bit: https://github.com/shekhardesigner/InvertImages/blob/master/jquery.invertImages.js

@nextcloud/designers @pixelipo

@juliusknorr juliusknorr added bug design Design, UI, UX, etc. 1. to develop Accepted and waiting to be taken care of labels Mar 7, 2018
@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 20, 2018
@jancborchardt
Copy link
Member

cc @skjnldsv @nextcloud/designers since we talked about this in the #9862 accessibility pull request.

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jun 23, 2018
@MorrisJobke
Copy link
Member

Fix is in #9984

@juliusknorr
Copy link
Member Author

Not yet fixed, #9984 is the foundation of it, we still need to get rid of the invert filter and load the icons with white color for the icon-white class. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants