Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPDX header #448

Merged
merged 13 commits into from
Jul 31, 2024
Merged

Add SPDX header #448

merged 13 commits into from
Jul 31, 2024

Conversation

AndyScherzinger
Copy link
Member

No description provided.

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Jul 1, 2024
@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 3 times, most recently from 0d38674 to bacb193 Compare July 7, 2024 16:07
@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Jul 7, 2024
@AndyScherzinger
Copy link
Member Author

@susnux any idea why the .LICENSE.txt still get generated? Also any hints on why some files don't get updated in terms of *.license files not being generated for them? https://github.com/nextcloud/related_resources/actions/runs/9828654848/job/27132839555?pr=448#step:4:6

Also for https://github.com/nextcloud/related_resources/pull/448/files#diff-f8dd00715c5654f589042f3de156e3505f0a916baaeb0987e64898808706a152R33-R35 I assume we can remove them, so leave that empty or remove the block?

Thanks in advance for your help 🙏

@AndyScherzinger AndyScherzinger force-pushed the chore/noid/spdx branch 4 times, most recently from 70a6c61 to 6afcee7 Compare July 9, 2024 16:37
@AndyScherzinger AndyScherzinger added 2. developing Work in progress needs info Not enough information provided labels Jul 9, 2024
@AndyScherzinger AndyScherzinger removed the 2. developing Work in progress label Jul 9, 2024
@blizzz blizzz mentioned this pull request Jul 30, 2024
Merged
@AndyScherzinger
Copy link
Member Author

@susnux any idea why for 2 assets there is no license file being generated?

The following files have no copyright and licensing information:
* js/vendors-node_modules_nextcloud_vue_dist_Components_NcRelatedResourcesPanel_js.related_resources.js
* js/vendors-node_modules_nextcloud_vue_dist_Components_NcRelatedResourcesPanel_js.related_resources.js.map

AndyScherzinger and others added 10 commits July 31, 2024 10:32
@AndyScherzinger
chore: Add SPDX header
73f83ea 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
chore: convert reuse to toml file
4ca80d6 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
ci: Add REUSE check
c0c4cc6 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
docs: Add RESUE compliance status check
7ea092e 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
chore: Add missing license
14bc7d9 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger @susnux
chore: Add WebpackSPDXPlugin to extract license information of built …
6369a5f 
…assets

Co-authored-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
fix: make script git-executable
f69ed01 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
docs: improve license and author info
785188d 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
fix: Add missing licenses
994ed73 
Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
ci: remove LICENSE.txt generation
73437b2 
Signed-off-by: Andy Scherzinger <[email protected]>
@nextcloud-command @AndyScherzinger
chore(assets): Recompile assets
1cb88ce 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger
Copy link
Member Author

/compile /

@nextcloud-command
chore(assets): Recompile assets
b686fbb 
Signed-off-by: nextcloud-command <[email protected]>
@AndyScherzinger AndyScherzinger merged commit 2bd05bd into master Jul 31, 2024
29 checks passed
@AndyScherzinger AndyScherzinger deleted the chore/noid/spdx branch July 31, 2024 18:32
@blizzz blizzz mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner

@Pytal Pytal Awaiting requested review from Pytal Pytal is a code owner

@susnux susnux Awaiting requested review from susnux

Assignees
No one assigned
Labels
3. to review Waiting for reviews needs info Not enough information provided
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @nextcloud-command