Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge overlapping recipient popovers #8344

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Apr 11, 2023

  1. Popover for the recipient email
  2. Popover for Contacts integration

Now the contents are merged into one popover.

Before After
Bildschirmfoto vom 2023-04-11 08-29-42 Bildschirmfoto vom 2023-04-11 08-30-33
Bildschirmfoto vom 2023-04-11 08-30-12

@rollanders @goulvench @dbielz @BroCanDo for review

Fixes #7884

Copy link

@BroCanDo BroCanDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I should've done it like this from the beginning :)

1) Popover for the recipient email
2) Popover for Contacts integration

Now the contents are merged into one popover.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst merged commit 33a8e0e into main Apr 12, 2023
@ChristophWurst ChristophWurst deleted the fix/message-recipient-addresses branch April 12, 2023 14:01
@ChristophWurst
Copy link
Member Author

/backport to stable3.1

@ChristophWurst
Copy link
Member Author

/backport to stable2.2

@ChristophWurst
Copy link
Member Author

/backport to 1.15

@ChristophWurst
Copy link
Member Author

/backport to stable1.15

@backportbot-nextcloud

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show senders e-mail adress
3 participants