-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mail address not visible #8379
Comments
#7884 (comment) is where this was brought up. @jancborchardt @nimishavijay how can we restructure this so it's both secure (sender email clearly visible by default) and looks good? |
There are 2 places where the email address can be shown but is currently hidden. The first is the list of participants in the header of the entire thread. Here you can see the participants' names and when you click on it to find out more, the email address appears in a popover but is immediately hidden by another popover with email actions. The popover which covers the email is currently not using any component, and looks visually very different from anything else we have. We can change this to an action menu with the email as the first item which cannot be clicked on. (I've not included the "Contacts with this email" part because it doesn't seem to work anywhere? At least not on the company instance?) The second place where this appears is in each message header. Here, only the name of the sender is shown. I would suggest we show the email address in another row in What do you think? cc @jancborchardt |
Excellent observation. Fixed with #8344 but not released.
I think the point of the feature request is that the email should not be hidden. See how other email clients handle it, or https://phishingquiz.withgoogle.com/.
Mobile users should be able to see phishing attacks too. We have to be careful here. |
Gmail doesn't show any participant information in the header of the thread, only in each message header. Current Outlook web and Protonmail also show it like Gmail But the new Outlook and Apple Mail don't show it at all, which is not the direction we want to go in Hence I would say it is okay to hide the email address in the thread header, while showing it properly in the message header.
True, we can show it on mobile also. Possibly move the actions somewhere else or hide them in the 3 dot menu. What do you think? |
Sounds good and I think that is a fair middleground between design and security 👍 |
Tracked in #8191. You can ignore the space issue for this change. We'll address it separately 👍 |
Steps to reproduce
Expected behavior
Finding the email address of the participants should be easy and intuitive
Actual behavior
When clicking on the participant label the email address gets immediately hidden
Mail app version
No response
Mailserver or service
No response
Operating system
No response
PHP engine version
None
Web server
None
Database
None
Additional info
No response
The text was updated successfully, but these errors were encountered: