Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature image and Grammarly #3209

Closed
hugovalters opened this issue Jun 5, 2020 · 9 comments
Closed

Signature image and Grammarly #3209

hugovalters opened this issue Jun 5, 2020 · 9 comments

Comments

@hugovalters
Copy link

Hello,

Is it possible to please add an option to allow an HTML signature or to allow us to add an image to the signature?

Also, I see that Grammarly don't show up on the e-mail composing, can you please check and change the e-mail text field to text or what is required so that Grammarly would work?

I think, that this module is very good but needs a bit improvement also one of the improvements would be if there would be shown better the unread emails not only making back headers, but also some additional icons like a green dot or something.

Thanks.

@ChristophWurst
Copy link
Member

Is it possible to please add an option to allow an HTML signature or to allow us to add an image to the signature?

Duplicate of #2733.

Also, I see that Grammarly don't show up on the e-mail composing, can you please check and change the e-mail text field to text or what is required so that Grammarly would work?

We use CKEditor. Does it work on the demos?

@hugovalters
Copy link
Author

hugovalters commented Jun 5, 2020

Hello,

I can confirm, that on CKEditor demos it also doesn't work.
But other sites like google translate and others Grammarly works perfect, I think it is Just some tag that is written different also in Github Grammarly works perfectly.

I think this could be a solution if you could please try it: https://dev.ckeditor.com/ticket/14332

and here is another article: ckeditor/ckeditor4#1350

https://stackoverflow.com/questions/40969965/how-to-integrate-with-grammarly

@no-response no-response bot removed the needs info label Jun 5, 2020
@ChristophWurst
Copy link
Member

we use ckeditor v5. those are older releases. would be great if you could dig a bit deeper to see if there are newer tickets for this. I'm not sure if we can add that data attribute so easily as described on SO as the element is rendered by the ckeditor lib.

@hugovalters
Copy link
Author

Please leave this ticket open, I will check next week for this.
I would like to help you make this app even better if you don't mind.

Thanks.

@no-response no-response bot removed the needs info label Jun 5, 2020
@ChristophWurst
Copy link
Member

Take your time :)

Of course we appreciate any help to improve this app. Thanks a lot :)

@hugovalters
Copy link
Author

@ChristophWurst
Copy link
Member

See #3209 (comment). That is for CKEditor 4. And we use 5.

@hugovalters
Copy link
Author

Hello,

As I see grammarly is now working in e-mail.
But I would like to know about signatures, will there be a option to add HTML signature and picture?

Thanks.

@ChristophWurst
Copy link
Member

Good to know this Grammarly issue is resolved.

Images support in message bodies and signatures is being worked on: #2733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants