-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to load images in signatures #2733
Comments
As briefly discussed in the dev channel, we need a permanent storage for these images. And then transform them into attachments when the messages is sent. As a step in between we could start with external images only. This isn't ideal. But for some cases like corporate logos, this might actually just do the job. |
Another thing that we could do is use ckeditor's base64 "storage". Of course this bloats messages, but for small images (like, again, logos) this could be fine. Maybe worth a consideration? 🤔 |
Good idea! What makes this more appealing is the fact that typically people stray away form large signatures as loading them becomes a pain if they are too large. So one could always specify a size limit? |
Absolutely! |
Would it make sense to have an interim solution where the image is hosted on a third-party site like imgur.com, and have the URL pasted in the signature so that it shows up and "looks like" the image is added to the signature itself? Something similar to what google is allowing in it's gmail settings? Just until you have figured out the way forward into making it a clean integration to core code? |
We could allow external images already, I think. It's basically what I meant to explain with
The app wouldn't need to care where the images are stored. We'd just need to find a way to not make the browser block these images with our strict CSP. |
If you could allow them already, it would go a long way for users! I understood what you meant, just wanted clarification. Because we could create an image with all the details normally found in the signature, like the example @JohnMaree posted in the OP, and just link that in there. I tried adding images a while back (like 3 weeks or so) and it was not working, but might be that one needs a specific syntax for the mail client/editor to understand this imported image? |
@ChristophWurst sorry but you closed the issue, but there is no solution provided. You said it's already possible to insert third-party image but you didn't explain the way to do it. There is no visible way in the UI. The exchange below sound quite strange. Why we should use third-party site to embed pictures in an app designed to work in context of storing and sharing content software ??? Why we can join picture as attachment but not inside the body ? Nextcloud Sharing Path App already deliver a way for Nextcloud to act as CDN. This process may apply to a specific folder dedicated to mail content. |
I never claimed that. Read my comment again. It just states that your feature request is a duplicate and we have an existing ticket for discussion.
Please carefully read the previous discussion. We want to have this, but it's not easy. So we would start small and add more advanced options gradually. But please change my mind and submit a pull request with the implementation. |
@ChristophWurst sorry but I made tow mistake |
Hello, but actually for Nextcloud you can use the cloud as temp storage, or the user can upload the Image into his cloud and use the public link. <--- This is Just as an idea. |
I'm looking into this right now. Adding the CKEditor plugin is easy. BUT you won't see the image when you compose the email as Nextcloud's strict CSP will block the image URL on the Nextcloud page. I think we'll start with the base64 insert option and the external hosting will follow later. |
This and only this. Please, give this a try. Or do it the way you think works and see that it doesn't. If you have any development questions use https://help.nextcloud.com/c/dev/app-dev/24. This is an issue tracker. |
That's actually really easy (to say) - namely they bundle every single referenced thing (especially pictures) with the email as separate But it's not easy to implement & test in terms of manhours needed if you think of it... |
@ChristophWurst sorry but I still don't get the second part of your explanation. However, the general idea is clear to me now. And as it is not really pleasant to have development discussions here let us not continue in it. I just want to add this link as it mentions the basic approaches to send images in emails (basically as explained above, but a bit more organized and colored), maybe this can help somebody. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
Hello, so I think this is a really good idea to have and as I scanned through the previous comments I thought of a couple ways that maybe this could be implemented. I am not a programmer so just giving some ideas...
If I missed any of these in the discussion I'm sorry, I tried to find if there were any similar postings. |
Hello, is there any movement on this? Thanks |
NextCloud devs should pay attention to this request. I’ve already accessed all the topics, including this one, also without solution. I believe that such a feature should be implemented on the platform, as it is a basic feature that many people need, especially when it comes to the use of internal compliance by companies. |
Welcome on GitHub @renatolinux 👋 Please take some time to familiarize yourself with GitHub. An issue is open or closed. Closed + Fixed by means, in most cases, that a feature was implemented. Fixed by is the reference for the pull request that implemented the feature. It's possible to add images in signatures since Mail 2.0.
"should pay attention" sounds very demanding. Please use it carefully, especially on GitHub. |
I see this is an old and complicated topic, some issues/request were fixed/implemented but i also i see that html signature does not work. |
@sturlan please read #2733 (comment) For help with the mail app: https://help.nextcloud.com/c/support/7 (category support, tag: mail-app) If you are sure it's a bug, then please log a new issue here. |
Feature Request
The ability for signatures for each account to have images is a common feature in most email clients.
Summary
The ability for signatures for each account to have images is a common feature in most email clients.
As an example:
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: