-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix overlapping toggle #5475
fix overlapping toggle #5475
Conversation
Signed-off-by: Simon L <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #5475 +/- ##
============================================
- Coverage 22.62% 22.61% -0.01%
Complexity 395 395
============================================
Files 241 241
Lines 11843 11848 +5
Branches 2305 2306 +1
============================================
Hits 2679 2679
- Misses 9164 9169 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Simon L <[email protected]>
@st3iny thanks for the review! I adjusted the PR. Please test again as it should work btter now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works.
/backport to stable4.5 |
This seems to fix it in firefox:
|
Close #5391