Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile menu toggle for navigation overlaps with content (especially in Mail & Contacts) #2

Closed
3 tasks done
Tracked by #73
tigernero79 opened this issue Aug 29, 2019 · 71 comments · Fixed by nextcloud/mail#6774 or nextcloud/calendar#5490
Assignees
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc.

Comments

@tigernero79
Copy link

tigernero79 commented Aug 29, 2019

mail application in the mobile version from this annoying overlap of the 3 lines that make the menu open with the first readable email.

I attach screenshot

63912980-e1f8dc00-ca2e-11e9-9b25-7bf53d05005c

Work packages

@ChristophWurst
Copy link
Member

Yep, it's hard to star the first message then.

cc @skjnldsv because this also affects any other app that uses the app content list with a star icon

Please use the bug template for bug reports next time. This makes it easier for us to triage and understand reports. Thanks.

@skjnldsv
Copy link
Member

Yeah, i had no idea so far, we have the same on contacts :)

@ChristophWurst
Copy link
Member

Yeah, i had no idea so far, we have the same on contacts :)

A problem shared is a problem halved.

Maybe we can find a better design for this. Any ideas @nextcloud/designers?

@jancborchardt
Copy link
Member

Yep, this is a problem in lots of places, especially in the apps using the app-content-list (Mail and Contacts as you said). The menu toggle was always an afterthought so far, and we should fix that.

Here’s 3 proposals:

  1. Half menu icon: This is how it used to be in Android. Not the best solution as people don’t see the menu icon and … what should be the clickable area? No wonder why Android moved away from this.
    menu placement1
  2. Menu + logo: Moving everything in the header over to insert a menu icon. This is a compromise still showing the logo, but will take a lot of space out of the header for icons. And well, there’s already so much stuff in the header.
    menu placement2
  3. Menu, no logo: Basically replacing the logo with the menu icon. This is of course the harshest because the logo will not be shown at all on mobile. But since the logo duplicates the primary app shortcut (in the default case Files) you could say that is ok.
    menu placement3

A middle ground we could go for is 2+3 depending on screen size. That is on tablets the logo would still be shown, but on smartphones not. Remember this view is only for the mobile web interface when you are logged in, so we kind of assume people use the mobile app, and do not necessarily need to see the logo.

Another addition to option 3: Since the menu icon is in the header, the navigation could open full-height and show the logo in the top part, just like we do in the Android app.

Any other ideas? And what do you think @nextcloud/designers?

Also cc @karlitschek @jospoortvliet since this is related to our branding.

@jancborchardt jancborchardt transferred this issue from nextcloud/mail Aug 30, 2019
@jancborchardt
Copy link
Member

Transferred to server repo as this is problem is more universal than just Mail.

@jancborchardt jancborchardt changed the title menu opening icon above the first email icon in the mobile version Mobile menu toggle for navigation overlaps with content (especially in Mail & Contacts) Aug 30, 2019
@karlitschek
Copy link
Member

Hmm. I'm not a fan of the proposals. Sorry. From an information hierarchical perspective the menu icon is part of the app. Not the header which is only a way to switch between apps. Also we shoild have our logo somewhere because it is the only place where we can show it. And together with the menu icon is looks crowded. I still think it should be somewhere in the app area.

@jancborchardt
Copy link
Member

Since it’s mainly an issue with the Contacts and Mail apps, here’s another proposal:

  • We actually make space for the menu icon in the content area, moving the first content further down.
  • The "New message"/"New contact" button can then also go to the top of the list of messages/contacts instead of the top of the navigation.
  • This moves it more in line of how we do it in Files with the "+ New" button being in the main content area, not in the navigation. Especially for Contacts this then also creates Contacts where they will appear, directly on top of the list.
  • On mobile, this makes the action directly available without needing to open the navigation.
  • When scrolling, the menu and "new" elements could scroll out of view, to appear immediately whenever you scroll up a bit. Kind of like we do it on our website with the navigation.

In Contacts app cc @nextcloud/contacts
Contacts app menu

In Mail app cc @nextcloud/mail
Mail app menu

What do you think @nextcloud/designers? Other proposals?

@skjnldsv
Copy link
Member

I'd say after all the hassle we had to standardise the new button in the navigation (used everywhere now: contacts, mail, calendar, notes, users management, quick notes...), removing it after 2 major is very confusing :)

@ChristophWurst you had the idea of a dedicated entry to refresh the mail list, wouldn't it solve your issue?

@skjnldsv
Copy link
Member

@karlitschek since this would be for mobile view only, I still think it make sense to replace our logo with the sidebar menu.
Our android and iOS apps doesn't show the logo in the header either? What do you think?

Our desktop would still show the default logo like it currently is :)

@karlitschek
Copy link
Member

Hmm. I think it is ok to do it on mobile only because of the limited space. But isn ´t it strange to have a different structure if the browser shrinks?

@skjnldsv
Copy link
Member

I'd say we already have a different structure on mobile as we show less information on the file list, we don't show the navigation... etc.
I'm sure we can find an ideal solution here :)

@georgehrke
Copy link
Member

Related issue about always showing the hamburger menu: nextcloud/server#15831

@jancborchardt
Copy link
Member

We just talked about it in the weekly design call, and will do that again next time. Some notes:

  • The overlap is mainly an issue with 3-column layout apps like Mail and Contacts
  • We need to keep in mind the request to always show the hamburger menu as @georgehrke mentioned above, that is also on desktop
  • With that style, the first mockups with the hamburger menu in the header would not work so nicely
  • The Deck app has it shown permanently on desktop already and it works quite nicely

We will discuss it again in the meeting next week @nextcloud/designers. If anyone has some ideas please start the mockup machine so we can weigh benefits. :) From my side the proposal is still https://github.com/nextcloud/server/issues/16934#issuecomment-526664888

@jancborchardt
Copy link
Member

We talked about this during the design call today and agreed (@juliushaertl @ma12-co @skjnldsv and I) that we’d do it like described above with keeping the hamburger menu where it is right now, moving the "New" buttons and shifting the start of the list down a bit.

Something we need to look into is how we do it in the Calendar app. If at some point we have continuous scrolling, it will essentially be a non-issue though. cc @georgehrke

From comment above https://github.com/nextcloud/server/issues/16934#issuecomment-526664888

In Contacts app cc @nextcloud/contacts
Contacts app menu

In Mail app cc @nextcloud/mail
Mail app menu

@stefan-niedermann
Copy link
Member

stefan-niedermann commented Oct 18, 2019

Might be relevant for the Notes app, too: https://github.com/nextcloud/notes/issues/392

@jancborchardt
Copy link
Member

@stefan-niedermann the issue you linked is actually a bit different, and in fact a bug with the menu handling. :) Thanks for referring it though, I transferred it to the server.

@tigernero79

This comment has been minimized.

@skjnldsv
Copy link
Member

skjnldsv commented Apr 1, 2020

@jancborchardt sicne we changed a bit the design specs to go for the search/new button like talk now, could you do some mockups or detailed specs on how it should look like now?

Once we go in mobile mode, we just slide the search/new buttons combo on top of the app-content? And put them back in their location if the navigation is opened? Any transitions you have in mind?

Thanks :)

@jancborchardt
Copy link
Member

sicne we changed a bit the design specs to go for the search/new button like talk now, could you do some mockups or detailed specs on how it should look like now?

The only thing that’s changed is search, and that’s on the top of the navigation. Regarding the "New" button for the 3-column layouts, the last proposal still stands.

Once we go in mobile mode, we just slide the search/new buttons combo on top of the app-content? And put them back in their location if the navigation is opened? Any transitions you have in mind?

The position will be the same regardless of mobile or desktop, anything else would be confusing and require special cases to maintain.

@BRadHoc
Copy link

BRadHoc commented Jun 3, 2020

Im experiencing this on ipad
IMG_0004

@jancborchardt
Copy link
Member

@BRadHoc that seems to be a different problem, could you open a separate issue with more info about this? Thanks! :)

@brylie
Copy link

brylie commented Oct 22, 2020

I think this sidebar menu should not "float" above content. Instead, it should be an inline element, that allows other content to respond when it resizes. That way, there wouldn't be any issue with the hamburger icon overlapping or, relatedly, the menu interfering with input on the primary content area.

@brylie
Copy link

brylie commented Oct 22, 2020

Here is an example where the floating sidebar obstructs the Create Contact form, with no way to hide it (the hamburger icon actually disappears).

Peek 2020-10-22 11-59

@brylie
Copy link

brylie commented Oct 22, 2020

Below is an example of how the sidebar could behave. Rather than obfuscating content, it simply uses the natural behavior of the browser to resize neighboring content as it expands.

inline expandable sidebar

https://medium.com/@9cv9official/create-a-beautiful-hover-triggered-expandable-sidebar-with-simple-html-css-and-javascript-9f5f80a908d1

@brylie
Copy link

brylie commented Oct 22, 2020

Note also that on a large screen, the Nextcloud sidebar actually behaves as described above. The sidebar is displayed inline and pushes the content aside as it expands.

Peek 2020-10-22 12-17

So, my suggestion is to preserve the large screen behavior on medium-to-small displays.

@paulcalabro
Copy link

paulcalabro commented Dec 30, 2020

I see this as well on NC v20.0.4

Mail App: seems a little crowded
Screen Shot 2020-12-30 at 10 01 41 AM

Settings: overlaps an icon
Screen Shot 2020-12-30 at 10 00 13 AM

Files: the toggle overlaps an icon
Screen Shot 2020-12-30 at 10 00 39 AM

...probably other apps as well.

If it helps, my screen resolution is: 3440 x 1440
Let me know if you need additional info.

@ya-d
Copy link

ya-d commented Feb 5, 2021

I‘m feeling bad for complaining without being able to offer any help. But…

This really is a nuisance and is making Nextcloud feel unfinished and not quite ready for production IMHO. As there seems to be such an obvious solution I’m really puzzled there hasn’t been any progress for over one and a halve years.

Plus, this would also serve the the issue that essential tasks (creating new items) are hidden from novice users which might not know where to look for them.

image

@marcoambrosini
Copy link
Member

As there seems to be such an obvious solution

This has already been solved in that exact way in files and deck. Whatever choice we take in talk, mail and contacts, I agree that this is making us look bad and needs immediate attention.

Screenshot from 2021-03-08 11-07-34

Screenshot from 2021-03-08 11-08-12

@ChristophWurst ChristophWurst moved this to 📐 Design phase in 🖍 Design team Jun 29, 2023
@ChristophWurst
Copy link
Member

  • To do: mockups and design specs

@jancborchardt jancborchardt self-assigned this Jul 19, 2023
@jancborchardt jancborchardt moved this from 📐 Design phase to 🕶️ Design review in 🖍 Design team Aug 2, 2023
@jancborchardt
Copy link
Member

Fixed now with nextcloud/calendar#5391

@github-project-automation github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Aug 3, 2023
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Aug 3, 2023
@ChristophWurst
Copy link
Member

nextcloud/calendar#5391 (comment)

@ChristophWurst ChristophWurst reopened this Aug 4, 2023
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do (~10 entries) in 💌 📅 👥 Groupware team Aug 4, 2023
@jancborchardt jancborchardt moved this from 🎉 Done to 📐 Design phase in 🖍 Design team Aug 31, 2023
@jancborchardt jancborchardt removed their assignment Sep 12, 2023
@szaimen szaimen self-assigned this Sep 12, 2023
@ChristophWurst ChristophWurst mentioned this issue Sep 14, 2023
13 tasks
@jancborchardt
Copy link
Member

The additional feedback by @raimund-schluessler was now fixed for good by @szaimen in nextcloud/calendar#5475 :)

@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 💌 📅 👥 Groupware team Sep 21, 2023
@github-project-automation github-project-automation bot moved this from 📐 Design phase to 🎉 Done in 🖍 Design team Sep 21, 2023
@raimund-schluessler
Copy link
Member

The additional feedback by @raimund-schluessler was now fixed for good by @szaimen in nextcloud/calendar#5475 :)

Well....

nextcloud/calendar#5475 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc.
Projects
Archived in project