Download limit for file link share #11563
Conversation
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11563.apk |
| @@ -0,0 +1,81 @@ | |||
| /* | |||
There was a problem hiding this comment.
Please move those RemoteOperation to android-library.
If possible, also add real end to end tests, else I can help you with them.
There was a problem hiding this comment.
Can you please grant me push access to android-library?
There was a problem hiding this comment.
@tobiasKaminsky I was writing IT for the download limit but I am facing issue in executing them in android-library.
- For parsing the test cases are running fine as there is no use of AbstractIT class.
- But for Operations (Get, Post, Delete) we need AbstractIT to be extended and for this the test cases are not executing. I tried existing test cases of NC but same for them.
Is there some configuration is required to execute them?
There was a problem hiding this comment.
Code moved to android-library: nextcloud/android-library#1123
|
I asked nextcloud/files_downloadlimit#173 to have a capability, as probably not that many server will have this enabled. |
AndyScherzinger
force-pushed
the
nmc/downloadLimitForFileLinkShare
branch
from
700c84f
to
f21db86
Compare
|
master-IT test failed, but no output was generated. Maybe a preliminary stage failed. |
|
test-Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
Implemented download limit for files where share type is Link.
Showing the download count once the download limit is specified.
Conditions to show download limit:
Required library PR: nextcloud/android-library#1123
Requires the implementation of: https://github.com/nextcloud/files_downloadlimit