Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download limit for file link share #1123

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

surinder-tsys
Copy link
Collaborator

Download limit related operations implementation.

PR relation: nextcloud/android#11563

Refer: https://github.com/nextcloud/files_downloadlimit

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

SpotBugs (master)

Warning Type Number
Bad practice Warnings 9
Correctness Warnings 40
Internationalization Warnings 6
Malicious code vulnerability Warnings 43
Multithreaded correctness Warnings 3
Performance Warnings 12
Security Warnings 1
Dodgy code Warnings 26
Total 140

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #1123 (303d296) into master (cd15911) will increase coverage by 51.05%.
The diff coverage is 34.04%.

❗ Current head 303d296 differs from pull request most recent head dabcece. Consider uploading reports for the commit dabcece to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1123       +/-   ##
===========================================
+ Coverage        0   51.05%   +51.05%     
===========================================
  Files           0      191      +191     
  Lines           0     7026     +7026     
  Branches        0      940      +940     
===========================================
+ Hits            0     3587     +3587     
- Misses          0     2937     +2937     
- Partials        0      502      +502     
Impacted Files Coverage Δ
...d_limit/DeleteShareDownloadLimitRemoteOperation.kt 0.00% <0.00%> (ø)
...s/download_limit/GetShareDownloadLimitOperation.kt 0.00% <0.00%> (ø)
...esources/download_limit/ShareDownloadLimitUtils.kt 0.00% <0.00%> (ø)
...d_limit/UpdateShareDownloadLimitRemoteOperation.kt 0.00% <0.00%> (ø)
...resources/download_limit/DownloadLimitXMLParser.kt 62.37% <62.37%> (ø)
...rces/download_limit/model/DownloadLimitResponse.kt 100.00% <100.00%> (ø)

... and 185 files with indirect coverage changes

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

SpotBugs (new)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

SpotBugs (master)

Warning Type Number
Bad practice Warnings 7
Correctness Warnings 34
Internationalization Warnings 6
Malicious code vulnerability Warnings 49
Multithreaded correctness Warnings 3
Performance Warnings 5
Dodgy code Warnings 27
Total 131

@nextcloud-android-bot
Copy link
Collaborator

@tobiasKaminsky
Copy link
Member

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants