Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] feat(Nc*Field): migrate from value to model-value #4647

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

raimund-schluessler
Copy link
Contributor

@raimund-schluessler raimund-schluessler commented Oct 13, 2023

☑️ Resolves

This migrates the Nc*Field components to use modelValue instead of value. This allows to simply use v-model="text" instead of v-model:value="text".

Depending on what gets merged first, either this PR or #4646 need to be adjusted.

Signed-off-by: Raimund Schlüßler <[email protected]>
@raimund-schluessler raimund-schluessler added 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Oct 13, 2023
@raimund-schluessler raimund-schluessler added this to the 9.0.0 next Vue 3 milestone Oct 13, 2023
@raimund-schluessler raimund-schluessler added the vue 3 Related to the vue 3 migration label Oct 13, 2023
@raimund-schluessler raimund-schluessler changed the title feat: migrate from value to model-value [next] feat(Nc*Field): migrate from value to model-value Oct 13, 2023
@Pytal Pytal merged commit 8837133 into next Oct 13, 2023
14 checks passed
@Pytal Pytal deleted the feat/2154/field-model-value branch October 13, 2023 21:40
@susnux susnux mentioned this pull request Jan 23, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... vue 3 Related to the vue 3 migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants