[next] feat(NcActions*): migrate to vue 3 #4646
Conversation
raimund-schluessler
added
3. to review
raimund-schluessler
changed the title
raimund-schluessler
requested review from
susnux,
skjnldsv,
Pytal,
ShGKme and
marcoambrosini
raimund-schluessler
force-pushed
the
feat/2154/actions
branch
from
ef61873
to
63c07e3
Compare
|
Rebased. |
raimund-schluessler
force-pushed
the
feat/2154/actions
branch
2 times, most recently
from
ffb7614
to
e117273
Compare
|
Resolved conflicts. |
|
Another review would be very welcome 🙂 |
Signed-off-by: Raimund Schlüßler <[email protected]>
raimund-schluessler
force-pushed
the
feat/2154/actions
branch
from
e117273
to
aa7e88b
Compare
|
Rebased and resolved conflicts. |
| before() { | ||
| // all actions requires a valid text content | ||
| // if none, forbid the component mount and throw error | ||
| if (!this.$slots.default || this.text.trim() === '') { | ||
| Vue.util.warn(`${this.$options.name} cannot be empty and requires a meaningful text content`, this) | ||
| if (!this.$slots.default() || this.text.trim() === '') { | ||
| warn(`${this.$options.name} cannot be empty and requires a meaningful text content`, this) |
There was a problem hiding this comment.
How does this part work? o_O
There was a problem hiding this comment.
What exactly do you mean? I didn't write it, originally, I only adjusted it for vue 3.
There was a problem hiding this comment.
Sorry, I missed that it was an old part. I just don't understand how it works in general, who and where call this before() custom option.
There was a problem hiding this comment.
Yes, I also find it a bit weird. Every Action* component, e.g. ActionButton uses this mixin to check that either text or the default slot are present.
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
Signed-off-by: Raimund Schlüßler <[email protected]>
|
@ShGKme Could you review again, please? I hope I fixed everything. |
|
@nextcloud-libraries/developers Honestly, it is a bit demotivating that very few seem to care that the components finally support vue 3. And at the risk of repeating myself: vue 2 reaches EOL in 45 business days. After that, it won't receive any more updates. Even if the risk for security issues in vue 2 is likely really low, it doesn't seem to be the best approach to not give developers at least the option to use supported libraries (especially for a project that always emphasizes to run up-to-date software). |
☑️ Resolves
This migrates the
NcActionscomponent to vue 3.