Move close button within modal boundaries #2738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoambrosini
requested review from
nickvergessen,
jancborchardt,
raimund-schluessler,
GretaD,
skjnldsv and
nimishavijay
marcoambrosini
added
bug
jancborchardt
approved these changes
Jun 7, 2022
|
I didn't test it, but the code looks good. I would just vote for having the default as |
marcoambrosini
changed the title
raimund-schluessler
requested changes
Jun 8, 2022
There was a problem hiding this comment.
Looks good and works as it should, only https://github.com/nextcloud/nextcloud-vue/pull/2738/files#r892030091 needs to be fixed.
Signed-off-by: Marco Ambrosini <[email protected]>
Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
bugfix/noid/put-the-close-button-into-the-modal
branch
from
e87b175
to
6069a1b
Compare
Signed-off-by: Marco Ambrosini <[email protected]>
raimund-schluessler
approved these changes
Jun 8, 2022
raimund-schluessler
deleted the
bugfix/noid/put-the-close-button-into-the-modal
branch
1 task
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2737
Screen.Recording.2022-06-07.at.16.23.01.mov
Signed-off-by: Marco Ambrosini [email protected]